This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new 08177a38eb Remove unneeded toString and valueOf calls (#2230)
08177a38eb is described below
commit 08177a38eb86cac7b7d14d788003cad6b140fe2e
Author: Elliotte Rusty Harold <[email protected]>
AuthorDate: Tue Apr 22 22:13:51 2025 +0000
Remove unneeded toString and valueOf calls (#2230)
* Remove unneeded toString and valueOf calls
---
.../apache/maven/artifact/versioning/ComparableVersion.java | 4 ++--
.../maven/repository/legacy/DefaultUpdateCheckManager.java | 4 ++--
.../maven/cli/transfer/AbstractMavenTransferListener.java | 4 ++--
.../java/org/apache/maven/plugin/logging/SystemStreamLog.java | 10 ++++------
.../maven/cling/transfer/AbstractMavenTransferListener.java | 4 ++--
.../org/apache/maven/plugin/DebugConfigurationListener.java | 2 +-
.../maven/impl/model/profile/ConditionProfileActivator.java | 2 +-
7 files changed, 14 insertions(+), 16 deletions(-)
diff --git
a/compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
b/compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
index 4b8f9a1ca0..6f84a85bd3 100644
---
a/compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
+++
b/compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
@@ -839,8 +839,8 @@ public static void main(String... args) {
if (prev != null) {
int compare = prev.compareTo(c);
- System.out.println(" " + prev.toString() + ' ' + ((compare
== 0) ? "==" : ((compare < 0) ? "<" : ">"))
- + ' ' + version);
+ System.out.println(
+ " " + prev + ' ' + ((compare == 0) ? "==" :
((compare < 0) ? "<" : ">")) + ' ' + version);
}
System.out.println(
diff --git
a/compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
b/compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
index ea2ca33a8c..d43758c997 100644
---
a/compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
+++
b/compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
@@ -243,8 +243,8 @@ private void writeLastUpdated(File touchfile, String key,
String error) {
} catch (IOException e) {
getLogger()
.debug(
- "Failed to record lastUpdated information for
resolution.\nFile: "
- + touchfile.toString() + "; key: " +
key,
+ "Failed to record lastUpdated information for
resolution.\nFile: " + touchfile
+ + "; key: " + key,
e);
} finally {
if (lock != null) {
diff --git
a/compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
b/compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
index bd6ab9da03..25a4097637 100644
---
a/compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
+++
b/compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java
@@ -205,7 +205,7 @@ public void transferInitiated(TransferEvent event) {
message.append(darkOn).append(":
").append(resource.getRepositoryUrl());
message.append(darkOff).append(resource.getResourceName());
- out.println(message.toString());
+ out.println(message);
}
@Override
@@ -242,6 +242,6 @@ public void transferSucceeded(TransferEvent event) {
}
message.append(')').append(darkOff);
- out.println(message.toString());
+ out.println(message);
}
}
diff --git
a/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/SystemStreamLog.java
b/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/SystemStreamLog.java
index b31f384769..bff8bf3295 100644
---
a/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/SystemStreamLog.java
+++
b/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/SystemStreamLog.java
@@ -108,8 +108,7 @@ public void error(CharSequence content, Throwable error) {
error.printStackTrace(pWriter);
- System.err.println(
- "[error] " + content.toString() + System.lineSeparator() +
System.lineSeparator() + sWriter.toString());
+ System.err.println("[error] " + content + System.lineSeparator() +
System.lineSeparator() + sWriter);
}
/**
@@ -121,7 +120,7 @@ public void error(Throwable error) {
error.printStackTrace(pWriter);
- System.err.println("[error] " + sWriter.toString());
+ System.err.println("[error] " + sWriter);
}
/**
@@ -163,7 +162,7 @@ private void print(String prefix, Throwable error) {
error.printStackTrace(pWriter);
- System.out.println("[" + prefix + "] " + sWriter.toString());
+ System.out.println("[" + prefix + "] " + sWriter);
}
private void print(String prefix, CharSequence content, Throwable error) {
@@ -172,7 +171,6 @@ private void print(String prefix, CharSequence content,
Throwable error) {
error.printStackTrace(pWriter);
- System.out.println("[" + prefix + "] " + content.toString() +
System.lineSeparator() + System.lineSeparator()
- + sWriter.toString());
+ System.out.println("[" + prefix + "] " + content +
System.lineSeparator() + System.lineSeparator() + sWriter);
}
}
diff --git
a/impl/maven-cli/src/main/java/org/apache/maven/cling/transfer/AbstractMavenTransferListener.java
b/impl/maven-cli/src/main/java/org/apache/maven/cling/transfer/AbstractMavenTransferListener.java
index a3985ec0cb..c1fef1d647 100644
---
a/impl/maven-cli/src/main/java/org/apache/maven/cling/transfer/AbstractMavenTransferListener.java
+++
b/impl/maven-cli/src/main/java/org/apache/maven/cling/transfer/AbstractMavenTransferListener.java
@@ -56,7 +56,7 @@ public void transferInitiated(TransferEvent event) {
message.style(STYLE).append(": ").append(resource.getRepositoryUrl());
message.resetStyle().append(resource.getResourceName());
- out.println(message.toString());
+ out.println(message);
}
@Override
@@ -93,6 +93,6 @@ public void transferSucceeded(TransferEvent event) {
}
message.append(')').resetStyle();
- out.println(message.toString());
+ out.println(message);
}
}
diff --git
a/impl/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
b/impl/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
index de20ea2a39..9400ec56f1 100644
---
a/impl/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
+++
b/impl/maven-core/src/main/java/org/apache/maven/plugin/DebugConfigurationListener.java
@@ -72,7 +72,7 @@ private String toString(Object obj) {
if (i > 0) {
buf.append(", ");
}
- buf.append(String.valueOf(Array.get(obj, i)));
+ buf.append(Array.get(obj, i));
}
buf.append(']');
str = buf.toString();
diff --git
a/impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/ConditionProfileActivator.java
b/impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/ConditionProfileActivator.java
index 95d1be2f4f..98aa2c0376 100644
---
a/impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/ConditionProfileActivator.java
+++
b/impl/maven-impl/src/main/java/org/apache/maven/impl/model/profile/ConditionProfileActivator.java
@@ -133,7 +133,7 @@ public Map<String, ConditionParser.ExpressionFunction>
registerFunctions(
if (!causeChain.isEmpty()) {
causeChain.append(" Caused by: ");
}
- causeChain.append(cause.toString());
+ causeChain.append(cause);
cause = cause.getCause();
}
throw new RuntimeException(
