This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
The following commit(s) were added to refs/heads/master by this push:
new a4f5c11a Replace always-passing asserts (#186)
a4f5c11a is described below
commit a4f5c11a09bc31d39c7fc494d86ca02efb3b29ed
Author: Elliotte Rusty Harold <[email protected]>
AuthorDate: Thu Jun 26 11:30:42 2025 +0000
Replace always-passing asserts (#186)
* Replace always-passing asserts
---
.../java/org/apache/maven/wagon/AbstractWagonTest.java | 10 +++++-----
.../test/java/org/apache/maven/wagon/StreamWagonTest.java | 14 +++++++-------
.../org/apache/maven/wagon/events/SessionEventTest.java | 2 +-
.../org/apache/maven/wagon/events/TransferEventTest.java | 4 ++--
.../apache/maven/wagon/observers/ChecksumObserverTest.java | 4 ++--
.../org/apache/maven/wagon/providers/ftp/FtpWagonTest.java | 2 +-
6 files changed, 18 insertions(+), 18 deletions(-)
diff --git
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/AbstractWagonTest.java
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/AbstractWagonTest.java
index e6ce9a89..712a48e1 100644
---
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/AbstractWagonTest.java
+++
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/AbstractWagonTest.java
@@ -233,7 +233,7 @@ public void
testSessionConnectionRefusedEventConnectionException() throws Except
runTestSessionConnectionRefusedEvent(exception);
fail();
} catch (ConnectionException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
@@ -244,7 +244,7 @@ public void
testSessionConnectionRefusedEventAuthenticationException() throws Ex
runTestSessionConnectionRefusedEvent(exception);
fail();
} catch (AuthenticationException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
@@ -306,7 +306,7 @@ protected void closeConnection() throws ConnectionException
{
wagon.disconnect();
fail();
} catch (ConnectionException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
} finally {
verify(sessionListener);
}
@@ -354,7 +354,7 @@ public void testGetError() throws Exception {
fail("Transfer error was expected during deploy");
} catch (TransferFailedException expected) {
- assertTrue(true);
+ assertNotNull(expected.getMessage());
}
verify(transferListener);
@@ -427,7 +427,7 @@ public void testConnectNullRepository() throws
ConnectionException, Authenticati
wagon.connect(null);
fail();
} catch (NullPointerException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
diff --git
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/StreamWagonTest.java
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/StreamWagonTest.java
index 59db8e63..1d6e684c 100644
---
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/StreamWagonTest.java
+++
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/StreamWagonTest.java
@@ -71,7 +71,7 @@ public void fillInputData(InputData inputData) {
wagon.getToStream("resource", new ByteArrayOutputStream());
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
} finally {
wagon.disconnect();
}
@@ -99,7 +99,7 @@ public void fillOutputData(OutputData inputData) {
wagon.putFromStream(new ByteArrayInputStream(new byte[0]),
"resource");
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
} finally {
wagon.disconnect();
}
@@ -112,7 +112,7 @@ public void testTransferFailedExceptionOnInput() throws
Exception {
runTestTransferError(new TransferFailedException(""));
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
@@ -136,7 +136,7 @@ public void fillOutputData(OutputData inputData) throws
TransferFailedException
wagon.putFromStream(new ByteArrayInputStream(new byte[0]),
"resource");
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
} finally {
wagon.disconnect();
verify(listener);
@@ -148,7 +148,7 @@ public void testResourceDoesNotExistException() throws
Exception {
runTestTransferError(new ResourceDoesNotExistException(""));
fail();
} catch (ResourceDoesNotExistException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
@@ -157,7 +157,7 @@ public void testAuthorizationException() throws Exception {
runTestTransferError(new AuthorizationException(""));
fail();
} catch (AuthorizationException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
@@ -411,7 +411,7 @@ public void testPutFileDoesntExist() throws Exception {
wagon.put(tempFile, "resource");
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
} finally {
wagon.disconnect();
}
diff --git
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
index f6738f54..be3fd1fc 100644
---
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
+++
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
@@ -96,7 +96,7 @@ public void testSessionEventProperties() throws
ConnectionException, Authenticat
event.setEventType(-1);
fail("Exception expected");
} catch (IllegalArgumentException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
diff --git
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
index 23a10389..e7476ed5 100644
---
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
+++
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
@@ -104,7 +104,7 @@ public void testTransferEventProperties() throws
ConnectionException, Authentica
fail("Exception expected");
} catch (IllegalArgumentException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
event.setEventType(TransferEvent.TRANSFER_COMPLETED);
@@ -128,7 +128,7 @@ public void testTransferEventProperties() throws
ConnectionException, Authentica
fail("Exception expected");
} catch (IllegalArgumentException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
diff --git
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/observers/ChecksumObserverTest.java
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/observers/ChecksumObserverTest.java
index 911ad1c3..ff8d7835 100644
---
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/observers/ChecksumObserverTest.java
+++
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/observers/ChecksumObserverTest.java
@@ -64,14 +64,14 @@ public void testSubsequentTransfersAfterTransferError()
wagon.get("resource", testFile);
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
try {
wagon.get("resource", testFile);
fail();
} catch (TransferFailedException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
testFile.delete();
diff --git
a/wagon-providers/wagon-ftp/src/test/java/org/apache/maven/wagon/providers/ftp/FtpWagonTest.java
b/wagon-providers/wagon-ftp/src/test/java/org/apache/maven/wagon/providers/ftp/FtpWagonTest.java
index f206d20f..dbc0065c 100644
---
a/wagon-providers/wagon-ftp/src/test/java/org/apache/maven/wagon/providers/ftp/FtpWagonTest.java
+++
b/wagon-providers/wagon-ftp/src/test/java/org/apache/maven/wagon/providers/ftp/FtpWagonTest.java
@@ -145,7 +145,7 @@ public void testNoPassword() throws Exception {
getWagon().connect(new Repository("id", getTestRepositoryUrl()),
authenticationInfo);
fail();
} catch (AuthenticationException e) {
- assertTrue(true);
+ assertNotNull(e.getMessage());
}
}
