(maven-rar-plugin) branch master updated: Be specific about exceptions (#128)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-rar-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 28b9e7f  Be specific about exceptions (#128)
28b9e7f is described below

commit 28b9e7f361967a840f363be3c51fe7d85338b265
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Tue Jul 8 11:38:47 2025 +0000

    Be specific about exceptions (#128)
    
    * Be specific about exceptions
---
 .../java/org/apache/maven/plugins/rar/RarMojo.java     | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/rar/RarMojo.java 
b/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
index 3ce6ae4..1344aed 100644
--- a/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
+++ b/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
@@ -50,6 +50,7 @@ import java.util.Set;
 import org.apache.maven.archiver.MavenArchiveConfiguration;
 import org.apache.maven.archiver.MavenArchiver;
 import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DependencyResolutionRequiredException;
 import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.model.Resource;
@@ -65,6 +66,7 @@ import 
org.apache.maven.shared.filtering.MavenFilteringException;
 import org.apache.maven.shared.filtering.MavenResourcesExecution;
 import org.apache.maven.shared.filtering.MavenResourcesFiltering;
 import org.codehaus.plexus.archiver.jar.JarArchiver;
+import org.codehaus.plexus.archiver.jar.ManifestException;
 import org.codehaus.plexus.util.FileUtils;
 
 /**
@@ -383,21 +385,21 @@ public class RarMojo extends AbstractMojo {
         }
 
         File rarFile = getRarFile(outputDirectory, finalName, classifier);
-        try {
-            MavenArchiver archiver = new MavenArchiver();
-            archiver.setArchiver(jarArchiver);
-            archiver.setCreatedBy("Maven RAR Plugin", 
"org.apache.maven.plugins", "maven-rar-plugin");
-            archiver.setOutputFile(rarFile);
+        MavenArchiver archiver = new MavenArchiver();
+        archiver.setArchiver(jarArchiver);
+        archiver.setCreatedBy("Maven RAR Plugin", "org.apache.maven.plugins", 
"maven-rar-plugin");
+        archiver.setOutputFile(rarFile);
 
-            // configure for Reproducible Builds based on outputTimestamp value
-            archiver.configureReproducibleBuild(outputTimestamp);
+        // configure for Reproducible Builds based on outputTimestamp value
+        archiver.configureReproducibleBuild(outputTimestamp);
 
+        try {
             // Include custom manifest if necessary
             includeCustomManifestFile();
 
             archiver.getArchiver().addDirectory(getBuildDir());
             archiver.createArchive(session, project, archive);
-        } catch (Exception e) {
+        } catch (IOException | ManifestException | 
DependencyResolutionRequiredException e) {
             throw new MojoExecutionException("Error assembling RAR", e);
         }