This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/maven-common-artifact-filters.git
The following commit(s) were added to refs/heads/master by this push:
new 2cc2c84 JUnit Jupiter best practices (#102)
2cc2c84 is described below
commit 2cc2c84077f6f5842758e260b067e4719aa41983
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Fri Nov 7 08:46:10 2025 +0100
JUnit Jupiter best practices (#102)
Co-authored-by: Moderne <[email protected]>
---
.../filter/collection/TestFilterArtifacts.java | 5 ++---
.../filter/collection/TestGroupIdFilter.java | 4 ++--
.../artifact/filter/collection/TestScopeFilter.java | 20 ++++++++++----------
.../artifact/filter/collection/TestTypeFilter.java | 3 +--
4 files changed, 15 insertions(+), 17 deletions(-)
diff --git
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestFilterArtifacts.java
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestFilterArtifacts.java
index c94c1a2..8097104 100644
---
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestFilterArtifacts.java
+++
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestFilterArtifacts.java
@@ -19,7 +19,6 @@
package org.apache.maven.shared.artifact.filter.collection;
import java.io.File;
-import java.io.IOException;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Set;
@@ -37,7 +36,7 @@ import static
org.junit.jupiter.api.Assertions.assertInstanceOf;
*/
class TestFilterArtifacts {
@Test
- void checkNullFilters() throws IOException, ArtifactFilterException {
+ void checkNullFilters() throws Exception {
// TODO: convert these old tests to use the abstract test case for dep
// plugin
@@ -102,7 +101,7 @@ class TestFilterArtifacts {
}
@Test
- void checkArtifactFilterWithClassifier() throws IOException,
ArtifactFilterException {
+ void checkArtifactFilterWithClassifier() throws Exception {
File outputFolder = new File("target/filters/");
FileUtils.deleteDirectory(outputFolder);
ArtifactStubFactory fact = new ArtifactStubFactory(outputFolder,
false);
diff --git
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestGroupIdFilter.java
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestGroupIdFilter.java
index 660e842..47cb466 100644
---
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestGroupIdFilter.java
+++
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestGroupIdFilter.java
@@ -90,7 +90,7 @@ class TestGroupIdFilter extends
AbstractArtifactFeatureFilterTest {
}
@Test
- void checkMultipleInclude() throws SecurityException,
IllegalArgumentException, ArtifactFilterException {
+ void checkMultipleInclude() throws Exception {
ArtifactsFilter filter = new GroupIdFilter("one,two", null);
assertEquals(4, artifacts.size());
@@ -101,7 +101,7 @@ class TestGroupIdFilter extends
AbstractArtifactFeatureFilterTest {
}
@Test
- void checkMultipleExclude() throws SecurityException,
IllegalArgumentException, ArtifactFilterException {
+ void checkMultipleExclude() throws Exception {
ArtifactsFilter filter = new GroupIdFilter(null, "one,two");
assertEquals(4, artifacts.size());
diff --git
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestScopeFilter.java
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestScopeFilter.java
index 2451ef3..b85132e 100644
---
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestScopeFilter.java
+++
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestScopeFilter.java
@@ -43,28 +43,28 @@ class TestScopeFilter {
}
@Test
- void checkScopeCompile() throws ArtifactFilterException {
+ void checkScopeCompile() throws Exception {
ScopeFilter filter = new ScopeFilter(Artifact.SCOPE_COMPILE, null);
Set<Artifact> result = filter.filter(artifacts);
assertEquals(3, result.size());
}
@Test
- void checkScopeRuntime() throws ArtifactFilterException {
+ void checkScopeRuntime() throws Exception {
ScopeFilter filter = new ScopeFilter(Artifact.SCOPE_RUNTIME, null);
Set<Artifact> result = filter.filter(artifacts);
assertEquals(2, result.size());
}
@Test
- void checkScopeTest() throws ArtifactFilterException {
+ void checkScopeTest() throws Exception {
ScopeFilter filter = new ScopeFilter(Artifact.SCOPE_TEST, null);
Set<Artifact> result = filter.filter(artifacts);
assertEquals(5, result.size());
}
@Test
- void checkScopeProvided() throws ArtifactFilterException {
+ void checkScopeProvided() throws Exception {
ScopeFilter filter = new ScopeFilter(Artifact.SCOPE_PROVIDED, null);
Set<Artifact> result = filter.filter(artifacts);
assertFalse(result.isEmpty());
@@ -74,7 +74,7 @@ class TestScopeFilter {
}
@Test
- void checkScopeSystem() throws ArtifactFilterException {
+ void checkScopeSystem() throws Exception {
ScopeFilter filter = new ScopeFilter(Artifact.SCOPE_SYSTEM, null);
Set<Artifact> result = filter.filter(artifacts);
assertFalse(result.isEmpty());
@@ -84,21 +84,21 @@ class TestScopeFilter {
}
@Test
- void checkScopeFilterNull() throws ArtifactFilterException {
+ void checkScopeFilterNull() throws Exception {
ScopeFilter filter = new ScopeFilter(null, null);
Set<Artifact> result = filter.filter(artifacts);
assertEquals(5, result.size());
}
@Test
- void checkScopeFilterEmpty() throws ArtifactFilterException {
+ void checkScopeFilterEmpty() throws Exception {
ScopeFilter filter = new ScopeFilter("", "");
Set<Artifact> result = filter.filter(artifacts);
assertEquals(5, result.size());
}
@Test
- void checkExcludeProvided() throws ArtifactFilterException {
+ void checkExcludeProvided() throws Exception {
ScopeFilter filter = new ScopeFilter("", Artifact.SCOPE_PROVIDED);
Set<Artifact> result = filter.filter(artifacts);
assertNotNull(result);
@@ -109,7 +109,7 @@ class TestScopeFilter {
}
@Test
- void checkExcludeSystem() throws ArtifactFilterException {
+ void checkExcludeSystem() throws Exception {
ScopeFilter filter = new ScopeFilter("", Artifact.SCOPE_SYSTEM);
Set<Artifact> result = filter.filter(artifacts);
assertNotNull(result);
@@ -120,7 +120,7 @@ class TestScopeFilter {
}
@Test
- void checkExcludeCompile() throws ArtifactFilterException {
+ void checkExcludeCompile() throws Exception {
ScopeFilter filter = new ScopeFilter("", Artifact.SCOPE_COMPILE);
Set<Artifact> result = filter.filter(artifacts);
assertEquals(2, result.size());
diff --git
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestTypeFilter.java
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestTypeFilter.java
index db7e013..d369884 100644
---
a/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestTypeFilter.java
+++
b/src/test/java/org/apache/maven/shared/artifact/filter/collection/TestTypeFilter.java
@@ -18,7 +18,6 @@
*/
package org.apache.maven.shared.artifact.filter.collection;
-import java.io.IOException;
import java.util.ArrayList;
import java.util.LinkedHashSet;
import java.util.List;
@@ -88,7 +87,7 @@ class TestTypeFilter {
}
@Test
- void checkFilteringOrder() throws IOException {
+ void checkFilteringOrder() throws Exception {
TypeFilter filter = new TypeFilter("war,jar", "zip");
Set<Artifact> artifacts = new LinkedHashSet<>();
