This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch check in repository https://gitbox.apache.org/repos/asf/maven-assembly-plugin.git
commit 229fd01f91719ab668abc470b05d1a2945273efc Author: Elliotte Rusty Harold <[email protected]> AuthorDate: Sun Nov 23 07:14:40 2025 -0600 Remove commented code --- .../maven/plugins/assembly/utils/FilterUtils.java | 9 ------- .../plugins/assembly/utils/ProjectUtilsTest.java | 28 ---------------------- 2 files changed, 37 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/assembly/utils/FilterUtils.java b/src/main/java/org/apache/maven/plugins/assembly/utils/FilterUtils.java index b0f54cf4..99b7e2c5 100644 --- a/src/main/java/org/apache/maven/plugins/assembly/utils/FilterUtils.java +++ b/src/main/java/org/apache/maven/plugins/assembly/utils/FilterUtils.java @@ -39,9 +39,6 @@ import org.apache.maven.shared.artifact.filter.StatisticsReportingArtifactFilter import org.apache.maven.shared.artifact.filter.resolve.ScopeFilter; import org.slf4j.Logger; -/** - * - */ public final class FilterUtils { private FilterUtils() {} @@ -125,12 +122,6 @@ public final class FilterUtils { allFilters.add(excludeFilter); } - // FIXME: Why is this added twice?? - // if ( additionalFilters != null && !additionalFilters.isEmpty() ) - // { - // allFilters.addAll( additionalFilters ); - // } - for (final Iterator<Artifact> it = artifacts.iterator(); it.hasNext(); ) { final Artifact artifact = it.next(); diff --git a/src/test/java/org/apache/maven/plugins/assembly/utils/ProjectUtilsTest.java b/src/test/java/org/apache/maven/plugins/assembly/utils/ProjectUtilsTest.java index 7633eea8..4f56f2b6 100644 --- a/src/test/java/org/apache/maven/plugins/assembly/utils/ProjectUtilsTest.java +++ b/src/test/java/org/apache/maven/plugins/assembly/utils/ProjectUtilsTest.java @@ -209,32 +209,4 @@ public class ProjectUtilsTest { } } - // private void verifyProjectsNotPresent( List verify, Set result ) - // { - // List verifyCopy = new ArrayList( verify ); - // - // for ( Iterator it = result.iterator(); it.hasNext(); ) - // { - // MavenProject project = (MavenProject) it.next(); - // - // for ( Iterator verifyIterator = verifyCopy.iterator(); verifyIterator.hasNext(); ) - // { - // MavenProject verification = (MavenProject) verifyIterator.next(); - // - // if ( verification.getId().equals( project.getId() ) ) - // { - // verifyIterator.remove(); - // } - // } - // } - // - // if ( verifyCopy.size() != verify.size() ) - // { - // List found = new ArrayList( verify ); - // found.removeAll( verifyCopy ); - // - // fail( "Failed to verify absence of: " + found ); - // } - // } - }
