This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch maven-3.9.x
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/maven-3.9.x by this push:
     new ec21f4bf22 Update formatting of prerequisites-requirements error to 
improve readability
ec21f4bf22 is described below

commit ec21f4bf223c3f2e5fda052d405e2b432fea8e7b
Author: Slawomir Jaranowski <[email protected]>
AuthorDate: Sat Dec 6 16:55:53 2025 +0100

    Update formatting of prerequisites-requirements error to improve readability
    
    Message at the end of error line is not readable ... so add some new lines 
and tabs to make it more readable
---
 .../apache/maven/plugin/MavenPluginPrerequisitesChecker.java   |  2 +-
 .../org/apache/maven/plugin/PluginIncompatibleException.java   |  6 +-----
 .../maven/plugin/internal/DefaultMavenPluginManager.java       | 10 +++++-----
 3 files changed, 7 insertions(+), 11 deletions(-)

diff --git 
a/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
 
b/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
index 46e9fe1346..28b04f889b 100644
--- 
a/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
+++ 
b/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java
@@ -31,7 +31,7 @@
 public interface MavenPluginPrerequisitesChecker extends 
Consumer<PluginDescriptor> {
     /**
      *
-     * @param pluginDescriptor
+     * @param pluginDescriptor the plugin descriptor to check
      * @throws IllegalStateException in case the checked prerequisites are not 
met
      */
     @Override
diff --git 
a/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java
 
b/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java
index d3c5edbf95..1e2c26168b 100644
--- 
a/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java
+++ 
b/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java
@@ -26,10 +26,6 @@
 public class PluginIncompatibleException extends PluginManagerException {
 
     public PluginIncompatibleException(Plugin plugin, String message) {
-        this(plugin, message, null);
-    }
-
-    public PluginIncompatibleException(Plugin plugin, String message, 
Throwable cause) {
-        super(plugin, message, cause);
+        super(plugin, message, (Throwable) null);
     }
 }
diff --git 
a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
 
b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
index 85ae59530d..5e80e0c652 100644
--- 
a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java
@@ -296,15 +296,15 @@ public void checkPrerequisites(PluginDescriptor 
pluginDescriptor) throws PluginI
         });
         // aggregate all exceptions
         if (!prerequisiteExceptions.isEmpty()) {
+            String ln = System.lineSeparator();
             String messages = prerequisiteExceptions.stream()
                     .map(IllegalStateException::getMessage)
-                    .collect(Collectors.joining(", "));
+                    .collect(Collectors.joining(ln + '\t'));
             PluginIncompatibleException pie = new PluginIncompatibleException(
                     pluginDescriptor.getPlugin(),
-                    "The plugin " + pluginDescriptor.getId() + " has unmet 
prerequisites: " + messages,
-                    prerequisiteExceptions.get(0));
-            // the first exception is added as cause, all other ones as 
suppressed exceptions
-            
prerequisiteExceptions.stream().skip(1).forEach(pie::addSuppressed);
+                    ln + "The plugin " + pluginDescriptor.getId() + " has 
unmet prerequisites: " + ln + '\t'
+                            + messages);
+            prerequisiteExceptions.forEach(pie::addSuppressed);
             throw pie;
         }
     }

Reply via email to