(maven-shared-utils) branch master updated: Prefer StringBuilder for local variables (#368)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git


The following commit(s) were added to refs/heads/master by this push:
     new 3fba762  Prefer StringBuilder for local variables (#368)
3fba762 is described below

commit 3fba762661bf780d4ee9450525bc8a33f8d1fd9c
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Fri Feb 6 21:16:00 2026 +0000

    Prefer StringBuilder for local variables (#368)
    
    * Prefer StringBuilder for local variables
    
    * StringBuilder
---
 src/main/java/org/apache/maven/shared/utils/StringUtils.java       | 4 ++--
 src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/utils/StringUtils.java 
b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
index f51f85b..36f874b 100644
--- a/src/main/java/org/apache/maven/shared/utils/StringUtils.java
+++ b/src/main/java/org/apache/maven/shared/utils/StringUtils.java
@@ -1321,7 +1321,7 @@ public class StringUtils {
             if (length == 0) {
                 return "";
             } else {
-                return new StringBuffer(length)
+                return new StringBuilder(length)
                         .append(Character.toLowerCase(str.charAt(0)))
                         .append(str, 1, length)
                         .toString();
@@ -1723,7 +1723,7 @@ public class StringUtils {
         if (str == null) {
             return null;
         }
-        return new StringBuffer(str).reverse().toString();
+        return new StringBuilder(str).reverse().toString();
     }
 
     /**
diff --git a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java 
b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
index 4adb278..c4a6b01 100644
--- a/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
+++ b/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java
@@ -206,7 +206,7 @@ public class XmlWriterUtil {
         int magicNumber = indentation.length() + columnSize - "-->".length() - 
1;
         String[] sentences = StringUtils.split(comment, CRLF);
 
-        StringBuffer line = new StringBuffer(indentation + "<!-- ");
+        StringBuilder line = new StringBuilder(indentation + "<!-- ");
         for (String sentence : sentences) {
             String[] words = StringUtils.split(sentence, " ");
             for (String word : words) {
@@ -221,7 +221,7 @@ public class XmlWriterUtil {
                         line.append("-->").append(CRLF);
                         writer.writeMarkup(line.toString());
                     }
-                    line = new StringBuffer(indentation + "<!-- ");
+                    line = new StringBuilder(indentation + "<!-- ");
                     line.append(word).append(' ');
                 } else {
                     line.append(word).append(' ');