(maven-dependency-analyzer) branch master updated: Implement missing tests and cleanup TODOs in DependencyVisitorTest

[sjaranowski]

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git


The following commit(s) were added to refs/heads/master by this push:
     new a7245cd  Implement missing tests and cleanup TODOs in 
DependencyVisitorTest
a7245cd is described below

commit a7245cda73bfb720c645594b3b185ebe96412af6
Author: Sanjana <sanju250...@gmail.com>
AuthorDate: Mon Feb 2 23:44:58 2026 +0530

    Implement missing tests and cleanup TODOs in DependencyVisitorTest
---
 .../analyzer/asm/DependencyVisitorTest.java        | 35 +++++++++++-----------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git 
a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
 
b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
index 7d814e7..18aab18 100644
--- 
a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
+++ 
b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyVisitorTest.java
@@ -150,9 +150,9 @@ class DependencyVisitorTest {
     void testVisitOuterClass() {
         // class a.b.c
         // {
-        //     class ...
-        //     {
-        //     }
+        // class ...
+        // {
+        // }
         // }
         visitor.visitOuterClass("a/b/c", null, null);
 
@@ -163,12 +163,12 @@ class DependencyVisitorTest {
     void testVisitOuterClassInMethod() {
         // class a.b.c
         // {
-        //     x.y.z x(p.q.r p)
-        //     {
-        //         class ...
-        //         {
-        //         }
-        //     }
+        // x.y.z x(p.q.r p)
+        // {
+        // class ...
+        // {
+        // }
+        // }
         // }
         visitor.visitOuterClass("a/b/c", "x", "(Lp/q/r;)Lx/y/z;");
 
@@ -204,10 +204,8 @@ class DependencyVisitorTest {
 
     @Test
     void testVisitInnerClass() {
-        // TODO: ensure innerName is correct
-
-        // class a.b.c { class x.y.z { } }
-        visitor.visitInnerClass("x/y/z", "a/b/c", "z", 0);
+        // class a.b.c { class x { } }
+        visitor.visitInnerClass("a/b/c$x", "a/b/c", "x", 0);
 
         assertThat(resultCollector.getDependencies()).isEmpty();
     }
@@ -230,10 +228,13 @@ class DependencyVisitorTest {
         assertThat(resultCollector.getDependencies()).containsOnly("a.b.c");
     }
 
-    // TODO: determine actual use of default values
-    // void testVisitFieldWithValue()
-    // {
-    // }
+    @Test
+    void testVisitFieldWithValue() {
+        // a.b.c a = x.y.z.class
+        assertVisitor(visitor.visitField(0, "a", "La/b/c;", null, 
Type.getType("Lx/y/z;")));
+
+        assertThat(resultCollector.getDependencies()).containsOnly("a.b.c", 
"x.y.z");
+    }
 
     @Test
     void testVisitFieldArray() {