Author: dennisl
Date: Sun Jan 13 09:17:30 2008
New Revision: 611601
URL: http://svn.apache.org/viewvc?rev=611601&view=rev
Log:
o Fix errors reported by Checkstyle.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMailMojo.java
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/Release.java
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMailMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMailMojo.java?rev=611601&r1=611600&r2=611601&view=diff
==============================================================================
---
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMailMojo.java
(original)
+++
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMailMojo.java
Sun Jan 13 09:17:30 2008
@@ -311,8 +311,8 @@
else if ( from == null || from.isEmpty() )
{
throw new MojoExecutionException(
- "<developers> section in your pom could not be empty: add a
<developer> entry or set the " +
- "mailSender parameter." );
+ "<developers> section in your pom could not be empty: add a
<developer> entry or set the "
+ + "mailSender parameter." );
}
else if ( fromDeveloperId == null )
{
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java?rev=611601&r1=611600&r2=611601&view=diff
==============================================================================
---
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java
(original)
+++
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/AnnouncementMojo.java
Sun Jan 13 09:17:30 2008
@@ -106,7 +106,7 @@
/**
* URL where the artifact can be downloaded. If not specified,
* no URL is used.
- *
+ *
* @parameter
*/
private String urlDownload;
@@ -373,7 +373,7 @@
{
pomVersion = pomVersion.substring( 0, pomVersion.length() -
SNAPSHOT_SUFFIX.length() );
}
- getLog().debug( "Found " + releases.size() + " releases.");
+ getLog().debug( "Found " + releases.size() + " releases." );
for ( int i = 0; i < releases.size(); i++ )
{
@@ -381,7 +381,7 @@
if ( getLog().isDebugEnabled() )
{
getLog().debug( "The release: " + release.getVersion()
- + " has " + release.getAction().size() + " actions.");
+ + " has " + release.getAction().size() + " actions." );
}
if ( release.getVersion() != null && release.getVersion().equals(
pomVersion ) )
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/Release.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/Release.java?rev=611601&r1=611600&r2=611601&view=diff
==============================================================================
---
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/Release.java
(original)
+++
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/Release.java
Sun Jan 13 09:17:30 2008
@@ -58,7 +58,7 @@
public List getAction()
{
- if (action == null)
+ if ( action == null )
{
action = new ArrayList();
}
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java?rev=611601&r1=611600&r2=611601&view=diff
==============================================================================
---
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
(original)
+++
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/jira/AbstractJiraDownloader.java
Sun Jan 13 09:17:30 2008
@@ -198,7 +198,7 @@
if ( typeParam != null )
{
- localFilter.append( "&type=" + typeParam);
+ localFilter.append( "&type=" + typeParam );
}
}
}
@@ -244,24 +244,25 @@
prepareBasicAuthentication( client );
boolean jiraAuthenticationSuccessful = false;
- if( isJiraAuthenticationConfigured() ) {
+ if ( isJiraAuthenticationConfigured() )
+ {
jiraAuthenticationSuccessful = doJiraAuthentication( client,
jiraUrl );
}
- if ( ( isJiraAuthenticationConfigured() &&
jiraAuthenticationSuccessful ) ||
- !isJiraAuthenticationConfigured() )
+ if ( ( isJiraAuthenticationConfigured() &&
jiraAuthenticationSuccessful )
+ || !isJiraAuthenticationConfigured() )
{
if ( jiraId == null || jiraId.length() == 0 )
{
- log.info( "The JIRA URL " +
project.getIssueManagement().getUrl() +
- " doesn't include a pid, trying to extract it from
JIRA." );
+ log.info( "The JIRA URL " +
project.getIssueManagement().getUrl()
+ + " doesn't include a pid, trying to extract it from
JIRA." );
jiraId = JiraHelper.getPidFromJira( log,
project.getIssueManagement().getUrl(), client );
}
if ( jiraId == null )
{
- getLog().error( "The issue management URL in the POM does
not include a pid," +
- " and it was not possible to extract it from the page
at that URL." );
+ getLog().error( "The issue management URL in the POM does
not include a pid,"
+ + " and it was not possible to extract it from the
page at that URL." );
}
else
{
@@ -570,7 +571,8 @@
getLog().info( "Downloading from JIRA was successful" );
}
- else {
+ else
+ {
getLog().warn( "Downloading from JIRA failed. Received: [" +
gm.getStatusCode() + "]" );
}
}
