This is an automated email from the ASF dual-hosted git repository.
slawekjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new 79d90806 Resolve plugins declared in pluginManagement for
resolve-plugins and go-offline
79d90806 is described below
commit 79d908062c5ee1d4c6a441c0c4e2432e87167f56
Author: Slawomir Jaranowski <[email protected]>
AuthorDate: Mon May 4 23:38:20 2026 +0200
Resolve plugins declared in pluginManagement for resolve-plugins and
go-offline
Parent POMs can declare plugin versions only in pluginManagement.
Such plugins should also be taken into account during resolution.
---
src/it/projects/resolve-plugins/pom.xml | 5 ++++
src/it/projects/resolve-plugins/verify.groovy | 27 ++++++++++++++++++++++
.../plugins/dependency/utils/ResolverUtil.java | 8 ++++++-
3 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/src/it/projects/resolve-plugins/pom.xml
b/src/it/projects/resolve-plugins/pom.xml
index c0df8915..afd3539f 100644
--- a/src/it/projects/resolve-plugins/pom.xml
+++ b/src/it/projects/resolve-plugins/pom.xml
@@ -44,6 +44,11 @@
<artifactId>maven-assembly-plugin</artifactId>
<version>3.7.1</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.10.0</version>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
diff --git a/src/it/projects/resolve-plugins/verify.groovy
b/src/it/projects/resolve-plugins/verify.groovy
new file mode 100644
index 00000000..f6b56e86
--- /dev/null
+++ b/src/it/projects/resolve-plugins/verify.groovy
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+def resolvedPlugins = new File(basedir, "target/resolved.txt").text
+
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-assembly-plugin:jar:") : "Expected plugin not
found in resolved plugins"
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-dependency-plugin:jar:") : "Expected plugin not
found in resolved plugins"
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-surefire-plugin:jar:") : "Expected plugin not
found in resolved plugins"
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-project-info-reports-plugin:jar:") : "Expected
plugin not found in resolved plugins"
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-failsafe-plugin:jar:") : "Expected plugin not
found in resolved plugins"
+assert resolvedPlugins.contains("
org.apache.maven.plugins:maven-surefire-report-plugin:jar:") : "Expected plugin
not found in resolved plugins"
diff --git
a/src/main/java/org/apache/maven/plugins/dependency/utils/ResolverUtil.java
b/src/main/java/org/apache/maven/plugins/dependency/utils/ResolverUtil.java
index 27e56e91..e135b47a 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/utils/ResolverUtil.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/utils/ResolverUtil.java
@@ -38,6 +38,7 @@ import org.apache.maven.execution.MavenSession;
import org.apache.maven.model.ModelBase;
import org.apache.maven.model.Plugin;
import org.apache.maven.model.PluginContainer;
+import org.apache.maven.model.PluginManagement;
import org.apache.maven.model.ReportPlugin;
import org.apache.maven.model.Reporting;
import org.apache.maven.project.MavenProject;
@@ -342,7 +343,7 @@ public class ResolverUtil {
}
/**
- * Retrieve all plugins used in project either in build or reporting
section.
+ * Retrieve all plugins used in a project either in the build, plugin
management, or reporting section.
*
* @param project a maven project
* @return a collection of plugins
@@ -358,9 +359,14 @@ public class ResolverUtil {
List<Plugin> projectPlugins = project.getBuild().getPlugins();
+ List<Plugin> managementPlugins =
Optional.ofNullable(project.getPluginManagement())
+ .map(PluginManagement::getPlugins)
+ .orElse(Collections.emptyList());
+
LinkedHashSet<Plugin> result = new
LinkedHashSet<>(reportPlugins.size() + projectPlugins.size());
result.addAll(reportPlugins);
result.addAll(projectPlugins);
+ result.addAll(managementPlugins);
return result;
}
