(maven-invoker) branch master updated: Remove some unused and redundant code (#172)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-invoker.git


The following commit(s) were added to refs/heads/master by this push:
     new e1d7cac  Remove some unused and redundant code (#172)
e1d7cac is described below

commit e1d7caca2df8b8038beded68b8281e84b732430a
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Mon May 11 12:03:06 2026 +0000

    Remove some unused and redundant code (#172)
    
    * Mark fields final
    
    * Clean up some unused and unneeded code
---
 .../maven/shared/invoker/InvocationRequest.java    |  2 +-
 .../maven/shared/invoker/PrintStreamLogger.java    |  4 +--
 .../invoker/MavenCommandLineBuilderTest.java       | 40 +++++-----------------
 3 files changed, 11 insertions(+), 35 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java 
b/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
index c53e654..e1a9e05 100644
--- a/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
+++ b/src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java
@@ -430,7 +430,7 @@ public interface InvocationRequest {
         /**
          * Warn checksum failures equivalent {@code --lax-checksums}.
          */
-        Warn;
+        Warn
     }
 
     // ----------------------------------------------------------------------
diff --git 
a/src/main/java/org/apache/maven/shared/invoker/PrintStreamLogger.java 
b/src/main/java/org/apache/maven/shared/invoker/PrintStreamLogger.java
index b7b1ab7..b360001 100644
--- a/src/main/java/org/apache/maven/shared/invoker/PrintStreamLogger.java
+++ b/src/main/java/org/apache/maven/shared/invoker/PrintStreamLogger.java
@@ -121,10 +121,10 @@ public class PrintStreamLogger implements InvokerLogger {
             }
 
             buffer.append("Error:\n");
-            buffer.append(writer.toString());
+            buffer.append(writer);
         }
 
-        out.println(buffer.toString());
+        out.println(buffer);
     }
 
     /** {@inheritDoc} */
diff --git 
a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
 
b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
index 030ad41..38439b4 100644
--- 
a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
+++ 
b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
@@ -165,38 +165,14 @@ class MavenCommandLineBuilderTest {
 
     @Test
     void shouldUseSystemOutLoggerWhenNoneSpecified() throws Exception {
-        setupTempMavenHomeIfMissing(false);
+        setupTempMavenHomeIfMissing();
 
         mclb.checkRequiredState();
     }
 
-    private File setupTempMavenHomeIfMissing(boolean forceDummy) throws 
Exception {
+    private File setupTempMavenHomeIfMissing() {
         String mavenHome = System.getProperty("maven.home");
-
-        File appDir;
-
-        if (forceDummy || (mavenHome == null) || !new 
File(mavenHome).exists()) {
-            appDir = Files.createDirectories(
-                            
temporaryFolder.resolve("invoker-tests").resolve("maven-home"))
-                    .toFile();
-
-            File binDir = new File(appDir, "bin");
-            binDir.mkdirs();
-
-            if (Os.isFamily(Os.FAMILY_WINDOWS)) {
-                createDummyFile(binDir, "mvn.bat");
-            } else {
-                createDummyFile(binDir, "mvn");
-            }
-
-            Properties props = System.getProperties();
-            props.setProperty("maven.home", appDir.getCanonicalPath());
-
-            System.setProperties(props);
-        } else {
-            appDir = new File(mavenHome);
-        }
-
+        File appDir = new File(mavenHome);
         return appDir;
     }
 
@@ -719,7 +695,7 @@ class MavenCommandLineBuilderTest {
     }
 
     @Test
-    void shouldSpecifySingleGoalFromRequestArg() throws Exception {
+    void shouldSpecifySingleGoalFromRequestArg() {
 
         mclb.setArgs(newRequest().addArg("test"), cli);
 
@@ -740,7 +716,7 @@ class MavenCommandLineBuilderTest {
     }
 
     @Test
-    void shouldSpecifyTwoGoalsFromRequestArgs() throws Exception {
+    void shouldSpecifyTwoGoalsFromRequestArgs() {
         List<String> goals = new ArrayList<>();
         goals.add("test");
         goals.add("clean");
@@ -760,7 +736,7 @@ class MavenCommandLineBuilderTest {
 
     @Test
     void buildTypicalMavenInvocationEndToEnd() throws Exception {
-        File mavenDir = setupTempMavenHomeIfMissing(false);
+        File mavenDir = setupTempMavenHomeIfMissing();
 
         InvocationRequest request = newRequest();
 
@@ -813,7 +789,7 @@ class MavenCommandLineBuilderTest {
 
     @Test
     void shouldInsertActivatedProfiles() throws Exception {
-        setupTempMavenHomeIfMissing(false);
+        setupTempMavenHomeIfMissing();
 
         String profile1 = "profile-1";
         String profile2 = "profile-2";
@@ -870,7 +846,7 @@ class MavenCommandLineBuilderTest {
 
     @Test
     void addShellEnvironment() throws Exception {
-        setupTempMavenHomeIfMissing(false);
+        setupTempMavenHomeIfMissing();
 
         InvocationRequest request = newRequest();