This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch fix/xpp3domwriter-null-dom in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git
commit 82bb523bbcae17a53696d8e0588e9b9ce86dd71a Author: Elliotte Rusty Harold <[email protected]> AuthorDate: Wed Jul 1 09:31:44 2026 -0400 Xpp3DomWriter: add explicit null check for dom parameter --- .../maven/shared/utils/xml/Xpp3DomWriter.java | 2 ++ .../maven/shared/utils/xml/Xpp3DomWriterTest.java | 32 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomWriter.java b/src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomWriter.java index 900f03f..2949a03 100644 --- a/src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomWriter.java +++ b/src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomWriter.java @@ -21,6 +21,7 @@ package org.apache.maven.shared.utils.xml; import java.io.IOException; import java.io.PrintWriter; import java.io.Writer; +import java.util.Objects; /** * @author Brett Porter @@ -62,6 +63,7 @@ public class Xpp3DomWriter { * @throws IOException if writing fails */ public static void write(XMLWriter xmlWriter, Xpp3Dom dom, boolean escape) throws IOException { + Objects.requireNonNull(dom, "dom must not be null"); xmlWriter.startElement(dom.getName()); String[] attributeNames = dom.getAttributeNames(); for (String attributeName : attributeNames) { diff --git a/src/test/java/org/apache/maven/shared/utils/xml/Xpp3DomWriterTest.java b/src/test/java/org/apache/maven/shared/utils/xml/Xpp3DomWriterTest.java new file mode 100644 index 0000000..20b8de9 --- /dev/null +++ b/src/test/java/org/apache/maven/shared/utils/xml/Xpp3DomWriterTest.java @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.shared.utils.xml; + +import java.io.StringWriter; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertThrows; + +class Xpp3DomWriterTest { + @Test + void writeNullDom() { + assertThrows(NullPointerException.class, () -> Xpp3DomWriter.write(new StringWriter(), null)); + } +}
