(maven-shade-plugin) 03/03: Configure the NOTICE transformer in one pass over the transformers

[slachiewicz]

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git

commit f4dcb0b4535da7a8be8f663062354c1cf321cca2
Author: Sylwester Lachiewicz <slachiew...@apache.org>
AuthorDate: Tue Oct 27 23:53:08 2026 +0000

    Configure the NOTICE transformer in one pass over the transformers
---
 .../apache/maven/plugins/shade/mojo/ShadeMojo.java  | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java 
b/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
index 0928303d..d74f5a73 100644
--- a/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
+++ b/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
@@ -989,23 +989,22 @@ public class ShadeMojo extends AbstractMojo {
         if (transformers == null) {
             return Collections.emptyList();
         }
-        for (ResourceTransformer transformer : transformers) {
-            if (transformer == null) {
-                throw new MojoExecutionException(
-                        "Failed to create shaded artifact: parameter 
transformers contains null (double-check XML attribute)");
-            }
-            if (transformer instanceof ApacheNoticeResourceTransformer) {
-                ((ApacheNoticeResourceTransformer) 
transformer).setProjectNameIfUnset(project.getName());
-            }
-        }
         String year = outputTimestampYear(outputTimestamp);
         if (year == null && outputTimestamp != null && 
outputTimestamp.length() > 1) {
             getLog().warn("Cannot read a year from outputTimestamp " + 
outputTimestamp
                     + "; a generated NOTICE uses the current year");
         }
         for (ResourceTransformer transformer : transformers) {
-            if (year != null && transformer instanceof 
ApacheNoticeResourceTransformer) {
-                ((ApacheNoticeResourceTransformer) 
transformer).setDefaultCopyrightYear(year);
+            if (transformer == null) {
+                throw new MojoExecutionException(
+                        "Failed to create shaded artifact: parameter 
transformers contains null (double-check XML attribute)");
+            }
+            if (transformer instanceof ApacheNoticeResourceTransformer) {
+                ApacheNoticeResourceTransformer notice = 
(ApacheNoticeResourceTransformer) transformer;
+                notice.setProjectNameIfUnset(project.getName());
+                if (year != null) {
+                    notice.setDefaultCopyrightYear(year);
+                }
             }
         }
         return Arrays.asList(transformers);