This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-site-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 5258d91d Pass the sink factory to every report
5258d91d is described below

commit 5258d91d5b68f71048ec87012fb33f6b08e11566
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Sun Oct 11 22:26:16 2026 +0200

    Pass the sink factory to every report
    
    Reporting API 4.1.0 declares generate(Sink, SinkFactory, Locale) on
    MavenReport and routes single-page reports to generate(Sink, Locale) by
    default. Do not restore the instanceof MavenMultiPageReport check: a report
    that drops the deprecated interface would get a null SinkFactory and lose
    its sub-pages.
---
 .../maven/plugins/site/render/ReportDocumentRenderer.java      | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
 
b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
index d9a71e1e..e7205eee 100644
--- 
a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
+++ 
b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
@@ -38,7 +38,6 @@ import org.apache.maven.doxia.siterenderer.SiteRenderer;
 import org.apache.maven.doxia.siterenderer.SiteRenderingContext;
 import org.apache.maven.doxia.siterenderer.sink.SiteRendererSink;
 import org.apache.maven.plugin.logging.Log;
-import org.apache.maven.reporting.MavenMultiPageReport;
 import org.apache.maven.reporting.MavenReport;
 import org.apache.maven.reporting.MavenReportException;
 import org.apache.maven.reporting.exec.MavenReportExecution;
@@ -188,13 +187,8 @@ public class ReportDocumentRenderer implements 
DocumentRenderer {
                 Thread.currentThread().setContextClassLoader(classLoader);
             }
 
-            if (report instanceof MavenMultiPageReport) {
-                // extended multi-page API
-                ((MavenMultiPageReport) report).generate(mainSink, 
multiPageSinkFactory, locale);
-            } else {
-                // old single-page-only API
-                report.generate(mainSink, locale);
-            }
+            // single-page reports implementing only generate(Sink, Locale) 
are reached through its default
+            report.generate(mainSink, multiPageSinkFactory, locale);
         } catch (MavenReportException e) {
             String report = (reportMojoInfo == null) ? ('"' + localReportName 
+ '"') : reportMojoInfo;
             throw new RendererException("Error generating " + report + " 
report", e);

Reply via email to