This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/master by this push:
     new 8786f60754 Remove @Named from maven-api-spi SPI interfaces (#13880)
8786f60754 is described below

commit 8786f60754a371617792e06b4920a420f0e65f74
Author: Guillaume Nodet <[email protected]>
AuthorDate: Sat Nov 7 15:20:55 2026 +0100

    Remove @Named from maven-api-spi SPI interfaces (#13880)
    
    @Named on a SPI interface has no functional effect:
    
    1. DiIndexProcessor (the annotation processor that generates
       META-INF/maven/org.apache.maven.api.di.Inject) is not configured
       on maven-api-spi, so no DI index is produced from this module.
    
    2. Even if it were, getDeclaredAnnotations() does not traverse
       implemented interfaces — Java does not inherit interface annotations
       to implementing classes (@Named is not @Inherited). An impl class
       would need @Named on its own declaration to be indexed.
    
    3. The annotation is therefore purely decorative and misleading:
       it creates the false impression that placing @Named on the interface
       is sufficient for implementations to be discovered by the DI
       container.
    
    Implementations that need to be discovered must annotate their own
    concrete class with @Named (and ensure DiIndexProcessor runs on their
    module so the class is added to the index).
    
    Affected interfaces: LanguageProvider, LifecycleProvider, ModelParser,
    ModelTransformer, PackagingProvider, PathScopeProvider,
    ProjectScopeProvider, PropertyContributor, SettingsParser, TypeProvider.
---
 .../src/main/java/org/apache/maven/api/spi/DialectProvider.java         | 2 --
 .../src/main/java/org/apache/maven/api/spi/LanguageProvider.java        | 2 --
 .../src/main/java/org/apache/maven/api/spi/LifecycleProvider.java       | 2 --
 .../src/main/java/org/apache/maven/api/spi/ModelDialectProvider.java    | 2 --
 .../src/main/java/org/apache/maven/api/spi/ModelParser.java             | 2 --
 .../src/main/java/org/apache/maven/api/spi/ModelTransformer.java        | 2 --
 .../src/main/java/org/apache/maven/api/spi/ModelWriter.java             | 2 --
 .../src/main/java/org/apache/maven/api/spi/PackagingProvider.java       | 2 --
 .../src/main/java/org/apache/maven/api/spi/PathScopeProvider.java       | 2 --
 .../src/main/java/org/apache/maven/api/spi/ProjectScopeProvider.java    | 2 --
 .../src/main/java/org/apache/maven/api/spi/PropertyContributor.java     | 2 --
 .../src/main/java/org/apache/maven/api/spi/SettingsParser.java          | 2 --
 .../src/main/java/org/apache/maven/api/spi/TypeProvider.java            | 2 --
 13 files changed, 26 deletions(-)

diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/DialectProvider.java 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/DialectProvider.java
index 4519443b46..7ca5e40d59 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/DialectProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/DialectProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.Dialect;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * SPI to extend the {@link org.apache.maven.api.Dialect} extensible enum with 
custom values.
@@ -30,5 +29,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface DialectProvider extends ExtensibleEnumProvider<Dialect> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LanguageProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LanguageProvider.java
index 7a2f77068f..8e8ecb1c24 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LanguageProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LanguageProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.Language;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link Language} 
implementations.
@@ -46,5 +45,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface LanguageProvider extends ExtensibleEnumProvider<Language> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProvider.java
index d37a327e52..a49f371671 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.Lifecycle;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link Lifecycle} 
implementations.
@@ -54,5 +53,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface LifecycleProvider extends ExtensibleEnumProvider<Lifecycle> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelDialectProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelDialectProvider.java
index 351066eaa2..aaf0d09ccb 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelDialectProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelDialectProvider.java
@@ -22,7 +22,6 @@
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
 import org.apache.maven.api.annotations.Nonnull;
-import org.apache.maven.api.di.Named;
 
 /**
  * SPI to provide a symmetric pair of {@link ModelParser} and {@link 
ModelWriter} for a given {@link Dialect}.
@@ -37,7 +36,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface ModelDialectProvider extends SpiService {
 
     /**
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java
index 601cf2b8f4..3f370e5a94 100644
--- a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java
+++ b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParser.java
@@ -26,7 +26,6 @@
 import org.apache.maven.api.annotations.Experimental;
 import org.apache.maven.api.annotations.Nonnull;
 import org.apache.maven.api.annotations.Nullable;
-import org.apache.maven.api.di.Named;
 import org.apache.maven.api.model.Model;
 import org.apache.maven.api.services.Source;
 
@@ -43,7 +42,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface ModelParser extends SpiService {
 
     /**
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelTransformer.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelTransformer.java
index 50cc193969..c6bd42c29d 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelTransformer.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelTransformer.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
 import org.apache.maven.api.annotations.Nonnull;
-import org.apache.maven.api.di.Named;
 import org.apache.maven.api.model.Model;
 
 /**
@@ -53,7 +52,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface ModelTransformer extends SpiService {
 
     /**
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelWriter.java 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelWriter.java
index 66c1389bda..b6f7459d0d 100644
--- a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelWriter.java
+++ b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelWriter.java
@@ -26,7 +26,6 @@
 import org.apache.maven.api.annotations.Experimental;
 import org.apache.maven.api.annotations.Nonnull;
 import org.apache.maven.api.annotations.Nullable;
-import org.apache.maven.api.di.Named;
 import org.apache.maven.api.model.Model;
 
 /**
@@ -42,7 +41,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface ModelWriter extends SpiService {
 
     /**
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PackagingProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PackagingProvider.java
index 2e2af56e82..2c3892155a 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PackagingProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PackagingProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.Packaging;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link Packaging} 
implementations.
@@ -49,5 +48,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface PackagingProvider extends ExtensibleEnumProvider<Packaging> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PathScopeProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PathScopeProvider.java
index 7d618ae110..b92dd47525 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PathScopeProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PathScopeProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.PathScope;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link PathScope} 
implementations.
@@ -49,5 +48,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface PathScopeProvider extends ExtensibleEnumProvider<PathScope> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ProjectScopeProvider.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ProjectScopeProvider.java
index bcd071e9be..06c63317af 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ProjectScopeProvider.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ProjectScopeProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.ProjectScope;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link ProjectScope} 
implementations.
@@ -46,5 +45,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface ProjectScopeProvider extends 
ExtensibleEnumProvider<ProjectScope> {}
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java
 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java
index 97bd4f2430..c78c746db8 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java
@@ -24,7 +24,6 @@
 import org.apache.maven.api.ProtoSession;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Component able to contribute to Maven session user properties. This SPI 
component is invoked
@@ -34,7 +33,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface PropertyContributor extends SpiService {
     /**
      * Invoked just before session is created with a mutable map that carries 
collected user properties so far.
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/SettingsParser.java 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/SettingsParser.java
index e276998171..e0f7fa963e 100644
--- 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/SettingsParser.java
+++ 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/SettingsParser.java
@@ -25,7 +25,6 @@
 import org.apache.maven.api.annotations.Experimental;
 import org.apache.maven.api.annotations.Nonnull;
 import org.apache.maven.api.annotations.Nullable;
-import org.apache.maven.api.di.Named;
 import org.apache.maven.api.services.Source;
 import org.apache.maven.api.settings.Settings;
 
@@ -43,7 +42,6 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface SettingsParser extends SpiService {
     /**
      * Option that can be specified in the options map. The value should be a 
{@code Boolean};
diff --git 
a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/TypeProvider.java 
b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/TypeProvider.java
index 1aa5bf78d8..f4a07e9a97 100644
--- a/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/TypeProvider.java
+++ b/api/maven-api-spi/src/main/java/org/apache/maven/api/spi/TypeProvider.java
@@ -21,7 +21,6 @@
 import org.apache.maven.api.Type;
 import org.apache.maven.api.annotations.Consumer;
 import org.apache.maven.api.annotations.Experimental;
-import org.apache.maven.api.di.Named;
 
 /**
  * Service provider interface for registering custom {@link Type} 
implementations.
@@ -51,5 +50,4 @@
  */
 @Experimental
 @Consumer
-@Named
 public interface TypeProvider extends ExtensibleEnumProvider<Type> {}

Reply via email to