This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git
commit 6c4912d669e8fa14cac059348ed3cb6f0d8e7da1 Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Sun Nov 8 20:54:05 2026 +0000 Compare the path, not the pattern, in MatchPattern.matchPatternStart altStr was derived from the pattern source, so the second check asked whether the pattern matches the start of itself and the method was always true for Ant patterns; DirectoryScanner then descended into every directory. plexus-utils has str.replace here. --- src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java | 2 +- .../java/org/apache/maven/shared/utils/io/MatchPatternsTest.java | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java b/src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java index f99a1de..1c7dfa0 100644 --- a/src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java +++ b/src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java @@ -92,7 +92,7 @@ public class MatchPattern { // a file to deal with, or we can definitely say this is an exclusion... return true; } else { - String altStr = source.replace('\\', '/'); + String altStr = str.replace('\\', '/'); return SelectorUtils.matchAntPathPatternStart(this, str, File.separator, isCaseSensitive) || SelectorUtils.matchAntPathPatternStart(this, altStr, "/", isCaseSensitive); diff --git a/src/test/java/org/apache/maven/shared/utils/io/MatchPatternsTest.java b/src/test/java/org/apache/maven/shared/utils/io/MatchPatternsTest.java index 32a324e..cad5785 100644 --- a/src/test/java/org/apache/maven/shared/utils/io/MatchPatternsTest.java +++ b/src/test/java/org/apache/maven/shared/utils/io/MatchPatternsTest.java @@ -28,6 +28,13 @@ import static org.junit.jupiter.api.Assertions.assertTrue; */ @SuppressWarnings("deprecation") public class MatchPatternsTest { + @Test + public void matchesPatternStart() { + MatchPatterns from = MatchPatterns.from("ABC/**"); + assertTrue(from.matchesPatternStart("ABC", true)); + assertFalse(from.matchesPatternStart("XYZ", true)); + } + @Test public void matches() { MatchPatterns from = MatchPatterns.from("ABC**", "CDE**");
