This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch maven-3.10.x
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/maven-3.10.x by this push:
     new 9e00cd4f2f [MNG-8369] Report a clear error for an unparsable 
extensions.xml
9e00cd4f2f is described below

commit 9e00cd4f2f12b10617b1dbd17a63297eb2af402d
Author: Arturo Bernal <[email protected]>
AuthorDate: Thu Nov 12 16:23:50 2026 +0100

    [MNG-8369] Report a clear error for an unparsable extensions.xml
    
    readCoreExtensionsDescriptor() let any failure from the XML parser escape 
as-is, so an empty or otherwise malformed .mvn/extensions.xml surfaced as a 
bare "input contained no data" EOFException with a full stack trace instead of 
a message naming the problem file.
    
    Wrap the parse failure in an IOException that names the extensions file, 
keeping the original exception as the cause so -e still shows the full chain.
    
    Fixes #10258
---
 .../src/main/java/org/apache/maven/cli/MavenCli.java       |  6 ++++--
 .../src/test/java/org/apache/maven/cli/MavenCliTest.java   | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java 
b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
index e4851b1499..ac2790cc20 100644
--- a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
+++ b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
@@ -847,11 +847,13 @@ protected void configure() {
         }
     }
 
-    private List<CoreExtension> readCoreExtensionsDescriptor(Path 
extensionsFile)
-            throws IOException, XmlPullParserException {
+    List<CoreExtension> readCoreExtensionsDescriptor(Path extensionsFile) 
throws IOException {
         CoreExtensionsXpp3Reader parser = new CoreExtensionsXpp3Reader();
         try (BufferedReader is = Files.newBufferedReader(extensionsFile, 
StandardCharsets.UTF_8)) {
             return parser.read(is).getExtensions();
+        } catch (IOException | XmlPullParserException e) {
+            throw new IOException(
+                    "Unable to parse core extensions descriptor " + 
extensionsFile + ": " + e.getMessage(), e);
         }
     }
 
diff --git 
a/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java 
b/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
index 6a5b4ae59e..78edda36a9 100644
--- a/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
+++ b/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
@@ -113,6 +113,20 @@ public void testReadPasswordRejectsMissingPassword() {
                         null, new 
ByteArrayInputStream("\n".getBytes(StandardCharsets.UTF_8)), "Password: "));
     }
 
+    /**
+     * An empty or otherwise unparsable extensions descriptor should fail with 
a message naming the file, not a bare
+     * {@code EOFException} from the XML parser (MNG-8369).
+     */
+    @Test
+    public void testReadCoreExtensionsDescriptorRejectsUnparsableFile(@TempDir 
Path tempDir) throws Exception {
+        Path extensionsFile = tempDir.resolve("extensions.xml");
+        Files.createFile(extensionsFile);
+
+        IOException e = assertThrows(IOException.class, () -> 
cli.readCoreExtensionsDescriptor(extensionsFile));
+
+        assertTrue(e.getMessage().contains(extensionsFile.toString()), 
e.getMessage());
+    }
+
     @Test
     public void testCalculateDegreeOfConcurrency() {
         assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("0"));

Reply via email to