This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-archiver.git


The following commit(s) were added to refs/heads/master by this push:
     new f9b3067  Use System.lineSeparator(), @Override and try-with-resources
f9b3067 is described below

commit f9b3067ad2a55dacf83045d09e7032b70a70a9f8
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Mon Nov 16 21:50:12 2026 +0000

    Use System.lineSeparator(), @Override and try-with-resources
---
 src/test/java/org/apache/maven/archiver/MavenArchiverTest.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java 
b/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java
index 63b7cb5..6900b5e 100644
--- a/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java
+++ b/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java
@@ -79,6 +79,7 @@ import static org.mockito.Mockito.when;
 
 class MavenArchiverTest {
     static class ArtifactComparator implements Comparator<Artifact> {
+        @Override
         public int compare(Artifact o1, Artifact o2) {
             return o1.getArtifactId().compareTo(o2.getArtifactId());
         }
@@ -136,6 +137,7 @@ class MavenArchiverTest {
 
         // there should be a mock or a setter for this field.
         ManifestConfiguration config = new ManifestConfiguration() {
+            @Override
             public boolean isAddExtensions() {
                 return true;
             }
@@ -213,6 +215,7 @@ class MavenArchiverTest {
             model.setArtifactId("dummy");
 
             MavenProject project = new MavenProject(model) {
+                @Override
                 public List<String> getRuntimeClasspathElements() {
                     return 
Collections.singletonList(tempFile.getAbsolutePath());
                 }
@@ -220,6 +223,7 @@ class MavenArchiverTest {
 
             // there should be a mock or a setter for this field.
             ManifestConfiguration manifestConfig = new ManifestConfiguration() 
{
+                @Override
                 public boolean isAddClasspath() {
                     return true;
                 }
@@ -315,7 +319,7 @@ class MavenArchiverTest {
         MavenSession session = getDummySession();
         MavenProject project = getDummyProject();
 
-        String ls = System.getProperty("line.separator");
+        String ls = System.lineSeparator();
         project.setDescription("foo " + ls + " bar ");
         MavenArchiveConfiguration config = new MavenArchiveConfiguration();
         config.setForced(true);
@@ -408,7 +412,7 @@ class MavenArchiverTest {
         MavenSession session = getDummySession();
         MavenProject project = getDummyProject();
 
-        String ls = System.getProperty("line.separator");
+        String ls = System.lineSeparator();
         project.setDescription("foo " + ls + " bar ");
         MavenArchiveConfiguration config = new MavenArchiveConfiguration();
         config.setForced(true);

Reply via email to