This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git
commit 9198ba3f1b81046bc757fdc121592f29feb424fc Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Mon Nov 16 22:02:49 2026 +0000 Use JUnit 5 assertions and Mockito best practices in tests --- .../dependency/analyzer/ClassFileVisitorUtilsTest.java | 12 ++++++------ .../shared/dependency/analyzer/DefaultClassAnalyzerTest.java | 6 +++--- .../dependency/analyzer/asm/ASMDependencyAnalyzerTest.java | 5 ++--- .../shared/dependency/analyzer/asm/ResultCollectorTest.java | 10 +++++----- .../DefaultMainDependencyClassesProviderTest.java | 3 +-- .../DefaultTestDependencyClassesProviderTest.java | 3 +-- .../WarMainDependencyClassesProviderTest.java | 5 ++--- 7 files changed, 20 insertions(+), 24 deletions(-) diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtilsTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtilsTest.java index fb644e8..fc93bbe 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtilsTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtilsTest.java @@ -64,7 +64,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptJar() throws IOException { + void testAcceptJar() throws Exception { Path path = Files.createTempFile(tempDir, "test", ".jar"); try (JarOutputStream out = new JarOutputStream(Files.newOutputStream(path))) { @@ -81,7 +81,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptJarWithNonClassEntry() throws IOException { + void testAcceptJarWithNonClassEntry() throws Exception { Path path = Files.createTempFile(tempDir, "test", ".jar"); try (JarOutputStream out = new JarOutputStream(Files.newOutputStream(path))) { @@ -94,7 +94,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptDir() throws IOException { + void testAcceptDir() throws Exception { Path dir = Files.createTempDirectory(tempDir, "d-a-test"); Path abDir = Files.createDirectories(dir.resolve("a/b")); @@ -112,7 +112,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptDirWithNonClassFile() throws IOException { + void testAcceptDirWithNonClassFile() throws Exception { Path dir = Files.createTempDirectory(tempDir, "d-a-test"); Path abDir = Files.createDirectories(dir.resolve("a/b")); @@ -124,7 +124,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptWithFile() throws IOException { + void testAcceptWithFile() throws Exception { Path path = Files.createTempFile(tempDir, "test", ".class"); URL url = path.toUri().toURL(); @@ -137,7 +137,7 @@ class ClassFileVisitorUtilsTest { } @Test - void testAcceptWithUnsupportedScheme() throws IOException { + void testAcceptWithUnsupportedScheme() throws Exception { URL url = new URL("http://localhost/"); try { diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultClassAnalyzerTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultClassAnalyzerTest.java index 96f9ab9..d794eda 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultClassAnalyzerTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/DefaultClassAnalyzerTest.java @@ -61,7 +61,7 @@ class DefaultClassAnalyzerTest { } @Test - void testAnalyzeWithJar() throws IOException { + void testAnalyzeWithJar() throws Exception { Set<String> expectedClasses = new HashSet<>(); expectedClasses.add("a.b.c"); expectedClasses.add("x.y.z"); @@ -73,7 +73,7 @@ class DefaultClassAnalyzerTest { } @Test - void testAnalyzeBadJar() throws IOException { + void testAnalyzeBadJar() throws Exception { // to reproduce MDEP-143 // corrupt the jar file by altering its contents ByteArrayOutputStream baos = new ByteArrayOutputStream(100); @@ -93,7 +93,7 @@ class DefaultClassAnalyzerTest { } @Test - void testAnalyzeDirectoryPreservesDollarClassNames() throws IOException { + void testAnalyzeDirectoryPreservesDollarClassNames() throws Exception { Path directory = Files.createDirectories(tempDir.resolve("classes/library")); Files.write(directory.resolve("Dollar$Class.class"), new byte[0]); Files.write(directory.resolve("Outer$Inner.class"), new byte[0]); diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java index 197ba6d..f886bc5 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java @@ -18,7 +18,6 @@ */ package org.apache.maven.shared.dependency.analyzer.asm; -import java.io.IOException; import java.net.URL; import java.nio.file.Path; import java.nio.file.Paths; @@ -47,7 +46,7 @@ class ASMDependencyAnalyzerTest { } @Test - void verifyImplicitClassReferenceIncludedInUsedClasses() throws IOException { + void verifyImplicitClassReferenceIncludedInUsedClasses() throws Exception { Path file = Paths.get("target/test-classes/org/apache/maven/shared/dependency/analyzer/testcases/analyze"); Set<String> result = analyzer.analyze(file.toUri().toURL()); @@ -56,7 +55,7 @@ class ASMDependencyAnalyzerTest { } @Test - void verifyExcludedClasses() throws IOException { + void verifyExcludedClasses() throws Exception { Path file = Paths.get("target/test-classes/org/apache/maven/shared/dependency/analyzer/testcases/analyze"); Set<String> result = diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java index 0fb7bd8..36ed3fa 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java @@ -54,7 +54,7 @@ class ResultCollectorTest { } @Test - void testJava11Invoke() throws IOException { + void testJava11Invoke() throws Exception { Path path = Paths.get( "src/test/resources/org/apache/maven/shared/dependency/analyzer/commons-bcel-issue362/Bcel362.classx"); DependencyClassFileVisitor visitor = new DependencyClassFileVisitor(); @@ -64,7 +64,7 @@ class ResultCollectorTest { } @Test - void testJava17DynamicInvokeRecord() throws IOException { + void testJava17DynamicInvokeRecord() throws Exception { Path path = Paths.get( "src/test/resources/org/apache/maven/shared/dependency/analyzer/record-invokedynamic/RecordInvokeDynamic.classx"); DependencyClassFileVisitor visitor = new DependencyClassFileVisitor(); @@ -102,7 +102,7 @@ class ResultCollectorTest { } @Test - void testArrayCases() throws IOException { + void testArrayCases() throws Exception { Set<String> dependencies = getDependencies(ArrayCases.class); assertThat(dependencies).doesNotContain("[I"); assertThat(dependencies).allSatisfy(dependency -> assertThat(dependency).doesNotStartWith("[")); @@ -110,7 +110,7 @@ class ResultCollectorTest { } @Test - void testNoMethodHandle() throws IOException { + void testNoMethodHandle() throws Exception { Set<String> dependencies = getDependencies(MethodHandleCases.class); for (String dependency : dependencies) { assertThat(dependency).doesNotStartWith("("); @@ -118,7 +118,7 @@ class ResultCollectorTest { } @Test - void testInnerClassNamePreserved() throws IOException { + void testInnerClassNamePreserved() throws Exception { Set<String> dependencies = getDependencies(InnerClassCase.class); assertThat(dependencies).contains("java.lang.System", "java.lang.invoke.MethodHandles$Lookup"); } diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultMainDependencyClassesProviderTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultMainDependencyClassesProviderTest.java index 29ccafb..cc164f6 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultMainDependencyClassesProviderTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultMainDependencyClassesProviderTest.java @@ -19,7 +19,6 @@ package org.apache.maven.shared.dependency.analyzer.dependencyclasses; import java.io.File; -import java.io.IOException; import java.util.Set; import org.apache.maven.model.Build; @@ -47,7 +46,7 @@ class DefaultMainDependencyClassesProviderTest { private DefaultMainDependencyClassesProvider provider; @Test - void mainOutputIsUsed() throws IOException { + void mainOutputIsUsed() throws Exception { MavenProject project = Mockito.mock(MavenProject.class); Build build = Mockito.mock(Build.class); when(project.getBuild()).thenReturn(build); diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultTestDependencyClassesProviderTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultTestDependencyClassesProviderTest.java index 8a2f3d3..2bd332b 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultTestDependencyClassesProviderTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/DefaultTestDependencyClassesProviderTest.java @@ -19,7 +19,6 @@ package org.apache.maven.shared.dependency.analyzer.dependencyclasses; import java.io.File; -import java.io.IOException; import java.util.Set; import org.apache.maven.model.Build; @@ -47,7 +46,7 @@ class DefaultTestDependencyClassesProviderTest { private DefaultTestDependencyClassesProvider provider; @Test - void testOutputIsUsed() throws IOException { + void testOutputIsUsed() throws Exception { MavenProject project = Mockito.mock(MavenProject.class); Build build = Mockito.mock(Build.class); when(project.getBuild()).thenReturn(build); diff --git a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/WarMainDependencyClassesProviderTest.java b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/WarMainDependencyClassesProviderTest.java index 91a548e..6eae507 100644 --- a/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/WarMainDependencyClassesProviderTest.java +++ b/src/test/java/org/apache/maven/shared/dependency/analyzer/dependencyclasses/WarMainDependencyClassesProviderTest.java @@ -18,7 +18,6 @@ */ package org.apache.maven.shared.dependency.analyzer.dependencyclasses; -import java.io.IOException; import java.net.URISyntaxException; import java.nio.file.Path; import java.nio.file.Paths; @@ -53,7 +52,7 @@ class WarMainDependencyClassesProviderTest { private final WarMainDependencyClassesProvider provider = new WarMainDependencyClassesProvider(); @Test - void parseDefaultWebXml() throws IOException, URISyntaxException { + void parseDefaultWebXml() throws Exception { Path basePath = Paths.get(getClass().getResource("/webapp").toURI()); when(project.getBasedir()).thenReturn(basePath.toFile()); when(project.getPackaging()).thenReturn("war"); @@ -67,7 +66,7 @@ class WarMainDependencyClassesProviderTest { } @Test - void noDefaultWebXml() throws IOException, URISyntaxException { + void noDefaultWebXml() throws Exception { Path basePath = Paths.get(getClass().getResource("/webapp/examples").toURI()); when(project.getBasedir()).thenReturn(basePath.toFile()); when(project.getPackaging()).thenReturn("war");
