This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-rar-plugin.git
The following commit(s) were added to refs/heads/master by this push:
new db3675b Use System.lineSeparator(), @Override and try-with-resources
db3675b is described below
commit db3675bd46e2d41bc02cd6aed3adc89b06fe2c00
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Tue Nov 17 03:39:51 2026 +0000
Use System.lineSeparator(), @Override and try-with-resources
---
.../java/org/apache/maven/plugins/rar/RarMojo.java | 1 +
.../plugins/rar/stubs/ArtifactHandlerStub.java | 1 +
.../maven/plugins/rar/stubs/RarArtifactStub.java | 24 ++++++++++++++++++++++
.../plugins/rar/stubs/RarMavenProjectStub.java | 8 ++++++++
.../plugins/rar/stubs/RarMavenProjectStub2.java | 1 +
.../plugins/rar/stubs/RarMavenProjectStub3.java | 1 +
6 files changed, 36 insertions(+)
diff --git a/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
b/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
index bf5c6e1..b55e5dc 100644
--- a/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
+++ b/src/main/java/org/apache/maven/plugins/rar/RarMojo.java
@@ -319,6 +319,7 @@ public class RarMojo extends AbstractMojo {
/**
* {@inheritDoc}
*/
+ @Override
public void execute() throws MojoExecutionException {
if (skip) {
diff --git
a/src/test/java/org/apache/maven/plugins/rar/stubs/ArtifactHandlerStub.java
b/src/test/java/org/apache/maven/plugins/rar/stubs/ArtifactHandlerStub.java
index 0ee574a..d252399 100644
--- a/src/test/java/org/apache/maven/plugins/rar/stubs/ArtifactHandlerStub.java
+++ b/src/test/java/org/apache/maven/plugins/rar/stubs/ArtifactHandlerStub.java
@@ -26,6 +26,7 @@ public class ArtifactHandlerStub extends
DefaultArtifactHandler {
super("jar");
}
+ @Override
public boolean isAddedToClasspath() {
return true;
}
diff --git
a/src/test/java/org/apache/maven/plugins/rar/stubs/RarArtifactStub.java
b/src/test/java/org/apache/maven/plugins/rar/stubs/RarArtifactStub.java
index bc30bee..bb5bfec 100644
--- a/src/test/java/org/apache/maven/plugins/rar/stubs/RarArtifactStub.java
+++ b/src/test/java/org/apache/maven/plugins/rar/stubs/RarArtifactStub.java
@@ -59,99 +59,123 @@ public class RarArtifactStub extends ArtifactStub {
private File file;
+ @Override
public String getArtifactId() {
return artifactId;
}
+ @Override
public void setArtifactId(String artifactId) {
this.artifactId = artifactId;
}
+ @Override
public File getFile() {
return file;
}
+ @Override
public void setFile(File file) {
this.file = file;
}
+ @Override
public String getGroupId() {
return groupId;
}
+ @Override
public void setGroupId(String groupId) {
this.groupId = groupId;
}
+ @Override
public boolean isOptional() {
return optional;
}
+ @Override
public void setOptional(boolean optional) {
this.optional = optional;
}
+ @Override
public String getScope() {
return scope;
}
+ @Override
public void setScope(String scope) {
this.scope = scope;
}
+ @Override
public String getVersion() {
return version;
}
+ @Override
public void setVersion(String version) {
this.version = version;
}
+ @Override
public String getId() {
return getGroupId() + ":" + getArtifactId() + ":" + getVersion();
}
+ @Override
public String getBaseVersion() {
return getVersion();
}
+ @Override
public VersionRange getVersionRange() {
return VersionRange.createFromVersion(this.version);
}
+ @Override
public ArtifactHandler getArtifactHandler() {
return new ArtifactHandler() {
+ @Override
public boolean isIncludesDependencies() {
return false;
}
+ @Override
public boolean isAddedToClasspath() {
return true;
}
+ @Override
public String getPackaging() {
return null;
}
+ @Override
public String getLanguage() {
return null;
}
+ @Override
public String getExtension() {
return null;
}
+ @Override
public String getDirectory() {
return null;
}
+ @Override
public String getClassifier() {
return null;
}
};
}
+ @Override
public String getType() {
return "rar";
}
diff --git
a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub.java
b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub.java
index 87fd44b..4d79fb7 100644
--- a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub.java
+++ b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub.java
@@ -73,26 +73,32 @@ public class RarMavenProjectStub extends MavenProject {
setBuild(build);
}
+ @Override
public String getGroupId() {
return "org.apache.maven.test";
}
+ @Override
public String getArtifactId() {
return "maven-rar-test";
}
+ @Override
public String getVersion() {
return "1.0-SNAPSHOT";
}
+ @Override
public File getFile() {
return new File(getBasedir(),
"src/test/resources/unit/basic-rar-test/plugin-config.xml");
}
+ @Override
public File getBasedir() {
return new File(PlexusExtension.getBasedir());
}
+ @Override
public Artifact getArtifact() {
Artifact artifact = new RarArtifactStub();
@@ -105,6 +111,7 @@ public class RarMavenProjectStub extends MavenProject {
return artifact;
}
+ @Override
public Set<Artifact> getArtifacts() {
Set<Artifact> artifacts = new HashSet<>();
@@ -114,6 +121,7 @@ public class RarMavenProjectStub extends MavenProject {
return artifacts;
}
+ @Override
public List<Artifact> getAttachedArtifacts() {
if (attachedArtifacts == null) {
attachedArtifacts = new ArrayList<>();
diff --git
a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub2.java
b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub2.java
index f0805d4..9ae5c0f 100644
--- a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub2.java
+++ b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub2.java
@@ -21,6 +21,7 @@ package org.apache.maven.plugins.rar.stubs;
import java.io.File;
public class RarMavenProjectStub2 extends RarMavenProjectStub {
+ @Override
public File getFile() {
return new File(getBasedir(),
"src/test/resources/unit/basic-rar-with-descriptor/plugin-config.xml");
}
diff --git
a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub3.java
b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub3.java
index 4fa2fc0..5d456b8 100644
--- a/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub3.java
+++ b/src/test/java/org/apache/maven/plugins/rar/stubs/RarMavenProjectStub3.java
@@ -21,6 +21,7 @@ package org.apache.maven.plugins.rar.stubs;
import java.io.File;
public class RarMavenProjectStub3 extends RarMavenProjectStub {
+ @Override
public File getFile() {
return new File(getBasedir(),
"src/test/resources/unit/basic-rar-with-manifest/plugin-config.xml");
}