This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-remote-resources-plugin.git
commit 7ab8298993fe067320bab9ea90642ff8e00c6ac9 Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 07:38:55 2026 +0000 Use JUnit 5 assertions and Mockito best practices in tests --- .../apache/maven/plugin/resources/remote/it/ITAttachToTestOnly.java | 4 +--- .../apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java | 4 +--- .../maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java | 4 +--- .../maven/plugin/resources/remote/it/ITFilterLocalOverride.java | 4 +--- .../apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java | 4 +--- .../remote/it/ITGenerateFromBundleWithTypeAndClassifier.java | 4 +--- .../maven/plugin/resources/remote/it/ITGenerateFromManagedBundle.java | 4 +--- .../maven/plugin/resources/remote/it/ITGenerateFromOverride.java | 4 +--- .../maven/plugin/resources/remote/it/ITGetDependencyProjects.java | 4 +--- .../maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java | 4 +--- .../org/apache/maven/plugin/resources/remote/it/ITSpdxLicenseId.java | 4 +--- .../maven/plugin/resources/remote/it/ITSupplementalArtifact.java | 4 +--- 12 files changed, 12 insertions(+), 36 deletions(-) diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITAttachToTestOnly.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITAttachToTestOnly.java index 70bbe45..6f74662 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITAttachToTestOnly.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITAttachToTestOnly.java @@ -19,9 +19,7 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; import java.io.InputStream; -import java.net.URISyntaxException; import java.nio.charset.StandardCharsets; import java.util.jar.JarFile; @@ -41,7 +39,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; */ public class ITAttachToTestOnly extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("attach-to-test-only"); MavenRunner verifier = TestUtils.newVerifier(new File(dir, "bundle")); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java index 485eefe..5e5af06 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITBadDependencyPoms.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -34,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; */ public class ITBadDependencyPoms extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("bad-dependency-poms"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java index d32e17b..0ddd9c6 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITCustomFilterDelimiter.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITCustomFilterDelimiter extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("custom-filter-delim"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITFilterLocalOverride.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITFilterLocalOverride.java index e3bc122..de6e3dc 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITFilterLocalOverride.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITFilterLocalOverride.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITFilterLocalOverride extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("filter-local-override"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java index 7d7749a..55a9d23 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundle.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITGenerateFromBundle extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("generate-from-bundle"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundleWithTypeAndClassifier.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundleWithTypeAndClassifier.java index 6c69173..0321b88 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundleWithTypeAndClassifier.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromBundleWithTypeAndClassifier.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITGenerateFromBundleWithTypeAndClassifier extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("generate-from-bundle-with-type-and-classifier"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromManagedBundle.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromManagedBundle.java index 739bdef..130d643 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromManagedBundle.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromManagedBundle.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITGenerateFromManagedBundle extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("generate-from-managed-bundle"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromOverride.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromOverride.java index d2dcab8..253247a 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromOverride.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGenerateFromOverride.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -31,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITGenerateFromOverride extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("generate-from-override"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGetDependencyProjects.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGetDependencyProjects.java index 684f37e..2e640de 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGetDependencyProjects.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITGetDependencyProjects.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -34,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; */ public class ITGetDependencyProjects extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("get-dependency-projects"); MavenRunner verifier; diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java index ef7c934..3472682 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITRunOnlyAtExecutionRoot.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -37,7 +35,7 @@ import static org.junit.jupiter.api.Assumptions.assumeTrue; */ public class ITRunOnlyAtExecutionRoot extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { // Workaround for Windows + Maven-3.5.x/3.6.0 + Jenkins due to MNG-6261 assumeTrue(!(System.getenv("JENKINS_HOME") != null && Os.isFamily(Os.FAMILY_WINDOWS) diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSpdxLicenseId.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSpdxLicenseId.java index 423d44a..8cc8d5f 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSpdxLicenseId.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSpdxLicenseId.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -32,7 +30,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ITSpdxLicenseId extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("spdx-license-id"); MavenRunner verifier = TestUtils.newVerifier(dir); diff --git a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSupplementalArtifact.java b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSupplementalArtifact.java index 1dbcf06..dfe716e 100644 --- a/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSupplementalArtifact.java +++ b/src/test/java/org/apache/maven/plugin/resources/remote/it/ITSupplementalArtifact.java @@ -19,8 +19,6 @@ package org.apache.maven.plugin.resources.remote.it; import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; import org.apache.maven.plugin.resources.remote.it.support.MavenRunner; import org.apache.maven.plugin.resources.remote.it.support.TestUtils; @@ -34,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; */ public class ITSupplementalArtifact extends AbstractIT { @Test - public void test() throws IOException, URISyntaxException { + public void test() throws Exception { File dir = TestUtils.getTestDir("supplemental-artifact"); File resources = new File(dir, "resource-projects");
