This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git

commit 87f71f4e67480d5547663d97c3eb6598440f2420
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Tue Nov 17 07:22:03 2026 +0000

    Use JUnit 5 assertions and Mockito best practices in tests
---
 src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java    | 2 +-
 src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java    | 9 +++++----
 .../java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java     | 3 +--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java 
b/src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java
index 4b6d591..24a7e9a 100644
--- a/src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java
+++ b/src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java
@@ -164,7 +164,7 @@ public class CpdReportTest {
     @InjectMojo(goal = "cpd", pom = "cpd-invalid-format-plugin-config.xml")
     @MojoParameter(name = "siteDirectory", value = "src/site")
     @Test
-    public void testInvalidFormat(CpdReport mojo) throws 
MojoExecutionException {
+    public void testInvalidFormat(CpdReport mojo) throws Exception {
         try {
             mojo.execute();
 
diff --git a/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java 
b/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
index 77f6f7c..429672d 100644
--- a/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
+++ b/src/test/java/org/apache/maven/plugins/pmd/PmdReportTest.java
@@ -47,6 +47,7 @@ import org.junit.jupiter.api.Test;
 import static org.apache.maven.api.plugin.testing.MojoExtension.getBasedir;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -445,7 +446,7 @@ public class PmdReportTest {
 
             fail("Must nested MavenReportException.");
         } catch (MojoExecutionException e) {
-            assertTrue(e.getCause() instanceof MavenReportException);
+            assertInstanceOf(MavenReportException.class, e.getCause());
         }
     }
 
@@ -459,7 +460,7 @@ public class PmdReportTest {
 
             fail("Must nested MavenReportException.");
         } catch (MojoExecutionException e) {
-            assertTrue(e.getCause() instanceof MavenReportException);
+            assertInstanceOf(MavenReportException.class, e.getCause());
         }
     }
 
@@ -893,13 +894,13 @@ public class PmdReportTest {
     }
 
     @Test
-    public void testCustomRenderer() throws MavenReportException {
+    public void testCustomRenderer() throws Exception {
         final Renderer renderer = 
PmdExecutor.createRenderer("net.sourceforge.pmd.renderers.TextRenderer", 
"UTF-8");
         assertNotNull(renderer);
     }
 
     @Test
-    public void testCodeClimateRenderer() throws MavenReportException {
+    public void testCodeClimateRenderer() throws Exception {
         final Renderer renderer =
                 
PmdExecutor.createRenderer("net.sourceforge.pmd.renderers.CodeClimateRenderer", 
"UTF-8");
         assertNotNull(renderer);
diff --git a/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java 
b/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
index 9039789..23bddd5 100644
--- a/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
+++ b/src/test/java/org/apache/maven/plugins/pmd/exec/ExecutorTest.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugins.pmd.exec;
 
 import java.io.File;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLClassLoader;
 
@@ -30,7 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class ExecutorTest {
     @Test
-    public void testBuildClasspath() throws MalformedURLException {
+    public void testBuildClasspath() throws Exception {
         String basename = "home/test/dir with space/mylib.jar";
         String pathname = new File("/", basename).getPath();
         if (SystemUtils.IS_OS_WINDOWS) {

Reply via email to