This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-ejb-plugin.git
commit 24eee1e6ae22414e1c79f4b152929ba45d512e34 Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 03:27:45 2026 +0000 Use System.lineSeparator(), @Override and try-with-resources --- src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java | 1 + .../apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java | 11 +++++++++++ .../apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java | 1 + .../java/org/apache/maven/plugins/ejb/stub/ModelStub.java | 9 +++++++++ 4 files changed, 22 insertions(+) diff --git a/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java b/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java index 0e0620e..34c1181 100644 --- a/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java +++ b/src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java @@ -284,6 +284,7 @@ public class EjbMojo extends AbstractMojo { /** * Generates an EJB jar and optionally an ejb-client jar. */ + @Override public void execute() throws MojoExecutionException { if (!sourceDirectory.exists()) { diff --git a/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java b/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java index 10b54f1..ed14ba9 100644 --- a/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java +++ b/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBasicStub.java @@ -71,18 +71,22 @@ public class MavenProjectBasicStub extends MavenProject { initializeParentFields(); } + @Override public String getName() { return "Test Project " + identifier; } + @Override public void setDescription(String desc) { description = desc; } + @Override public Model getModel() { return model; } + @Override public String getDescription() { if (description == null) { return "this is a test project"; @@ -91,16 +95,19 @@ public class MavenProjectBasicStub extends MavenProject { } } + @Override public File getBasedir() { // create an isolated environment // see setupTestEnvironment for details return new File(testRootDir); } + @Override public Artifact getArtifact() { return artifact; } + @Override public String getGroupId() { String groupId = getModel().getGroupId(); if ((groupId == null) && (getModel().getParent() != null)) { @@ -109,14 +116,17 @@ public class MavenProjectBasicStub extends MavenProject { return groupId; } + @Override public String getArtifactId() { return getModel().getArtifactId(); } + @Override public String getPackaging() { return "ejb"; } + @Override public String getVersion() { return identifier; } @@ -125,6 +135,7 @@ public class MavenProjectBasicStub extends MavenProject { properties.put(key, value); } + @Override public Properties getProperties() { return properties; } diff --git a/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java b/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java index ca6eef8..540f8d9 100644 --- a/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java +++ b/src/test/java/org/apache/maven/plugins/ejb/stub/MavenProjectBuildStub.java @@ -130,6 +130,7 @@ public class MavenProjectBuildStub extends MavenProjectBasicStub { return testResourcesDirectory; } + @Override public Build getBuild() { return build; } diff --git a/src/test/java/org/apache/maven/plugins/ejb/stub/ModelStub.java b/src/test/java/org/apache/maven/plugins/ejb/stub/ModelStub.java index b6eeb9d..7f4b19e 100644 --- a/src/test/java/org/apache/maven/plugins/ejb/stub/ModelStub.java +++ b/src/test/java/org/apache/maven/plugins/ejb/stub/ModelStub.java @@ -37,39 +37,48 @@ public class ModelStub extends Model { public ModelStub() {} + @Override public String getVersion() { return "0.0-TEST"; } + @Override public String getModelVersion() { return "0.0-TEST"; } + @Override public String getName() { return "Test Model"; } + @Override public String getGroupId() { return "org.apache.maven.test"; } + @Override public String getPackaging() { return "jar"; } + @Override public Parent getParent() { // return new Parent(); return null; } + @Override public String getArtifactId() { return "maven-test-plugin"; } + @Override public Properties getProperties() { return new Properties(); } + @Override public List<Profile> getProfiles() { return new LinkedList<>(); }
