This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-invoker-plugin.git
commit 0df1ebca496510b43fd430e6685e760d8beee21f Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 06:30:09 2026 +0000 Use System.lineSeparator(), @Override and try-with-resources --- .../org/apache/maven/plugins/invoker/AbstractInvokerMojo.java | 1 + .../java/org/apache/maven/plugins/invoker/CompositeMap.java | 11 +++++++++++ .../java/org/apache/maven/plugins/invoker/InstallMojo.java | 1 + .../org/apache/maven/plugins/invoker/IntegrationTestMojo.java | 1 + .../java/org/apache/maven/plugins/invoker/InvokerMojo.java | 1 + .../java/org/apache/maven/plugins/invoker/InvokerReport.java | 2 ++ .../java/org/apache/maven/plugins/invoker/ReportUtils.java | 1 + .../java/org/apache/maven/plugins/invoker/VerifyMojo.java | 1 + 8 files changed, 19 insertions(+) diff --git a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java index 8245f4b..11c3e3e 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java +++ b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java @@ -743,6 +743,7 @@ public abstract class AbstractInvokerMojo extends AbstractMojo { * @throws org.apache.maven.plugin.MojoExecutionException if the goal encountered severe errors * @throws org.apache.maven.plugin.MojoFailureException if any of the Maven builds failed */ + @Override public void execute() throws MojoExecutionException, MojoFailureException { if (skipInvocation) { getLog().info("Skipping invocation per configuration." diff --git a/src/main/java/org/apache/maven/plugins/invoker/CompositeMap.java b/src/main/java/org/apache/maven/plugins/invoker/CompositeMap.java index 1109762..b8cb063 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/CompositeMap.java +++ b/src/main/java/org/apache/maven/plugins/invoker/CompositeMap.java @@ -71,6 +71,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#clear() */ + @Override public void clear() { // nothing here } @@ -80,6 +81,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#containsKey(java.lang.Object) */ + @Override public boolean containsKey(Object key) { if (!(key instanceof String)) { return false; @@ -105,6 +107,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#containsValue(java.lang.Object) */ + @Override public boolean containsValue(Object value) { throw new UnsupportedOperationException(); } @@ -114,6 +117,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#entrySet() */ + @Override public Set<Entry<String, Object>> entrySet() { throw new UnsupportedOperationException(); } @@ -123,6 +127,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#get(java.lang.Object) */ + @Override public Object get(Object key) { if (!(key instanceof String)) { return null; @@ -165,6 +170,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#isEmpty() */ + @Override public boolean isEmpty() { return this.mavenProject.getProperties().isEmpty() && this.properties.isEmpty(); } @@ -174,6 +180,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#keySet() */ + @Override public Set<String> keySet() { throw new UnsupportedOperationException(); } @@ -183,6 +190,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#put(java.lang.Object, java.lang.Object) */ + @Override public Object put(String key, Object value) { throw new UnsupportedOperationException(); } @@ -201,6 +209,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#remove(java.lang.Object) */ + @Override public Object remove(Object key) { throw new UnsupportedOperationException(); } @@ -210,6 +219,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#size() */ + @Override public int size() { throw new UnsupportedOperationException(); } @@ -219,6 +229,7 @@ class CompositeMap implements Map<String, Object> { * * @see java.util.Map#values() */ + @Override public Collection<Object> values() { throw new UnsupportedOperationException(); } diff --git a/src/main/java/org/apache/maven/plugins/invoker/InstallMojo.java b/src/main/java/org/apache/maven/plugins/invoker/InstallMojo.java index 5a4389d..f5c4202 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/InstallMojo.java +++ b/src/main/java/org/apache/maven/plugins/invoker/InstallMojo.java @@ -160,6 +160,7 @@ public class InstallMojo extends AbstractMojo { * * @throws MojoExecutionException If the artifacts could not be installed. */ + @Override public void execute() throws MojoExecutionException { if (skipInstallation) { getLog().info("Skipping artifact installation per configuration."); diff --git a/src/main/java/org/apache/maven/plugins/invoker/IntegrationTestMojo.java b/src/main/java/org/apache/maven/plugins/invoker/IntegrationTestMojo.java index 977c331..97ab4b3 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/IntegrationTestMojo.java +++ b/src/main/java/org/apache/maven/plugins/invoker/IntegrationTestMojo.java @@ -53,6 +53,7 @@ public class IntegrationTestMojo extends AbstractInvokerMojo { super(invoker, settingsBuilder, toolchainManagerPrivate, interpolatorUtils); } + @Override void processResults(InvokerSession invokerSession) throws MojoFailureException { // do nothing } diff --git a/src/main/java/org/apache/maven/plugins/invoker/InvokerMojo.java b/src/main/java/org/apache/maven/plugins/invoker/InvokerMojo.java index 0a80e89..99ba43d 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/InvokerMojo.java +++ b/src/main/java/org/apache/maven/plugins/invoker/InvokerMojo.java @@ -80,6 +80,7 @@ public class InvokerMojo extends AbstractInvokerMojo { super(invoker, settingsBuilder, toolchainManager, interpolaterUtils); } + @Override void processResults(InvokerSession invokerSession) throws MojoFailureException { if (streamLogsOnFailures) { invokerSession.logFailedBuildLog(getLog(), ignoreFailures); diff --git a/src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java b/src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java index 20f9536..6eab795 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java +++ b/src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java @@ -90,11 +90,13 @@ public class InvokerReport extends AbstractMavenReport { } /** {@inheritDoc} */ + @Override public String getName(Locale locale) { return getI18nString(locale, "name"); } /** {@inheritDoc} */ + @Override public String getDescription(Locale locale) { return getI18nString(locale, "description"); } diff --git a/src/main/java/org/apache/maven/plugins/invoker/ReportUtils.java b/src/main/java/org/apache/maven/plugins/invoker/ReportUtils.java index c0ba504..b79fd44 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/ReportUtils.java +++ b/src/main/java/org/apache/maven/plugins/invoker/ReportUtils.java @@ -30,6 +30,7 @@ class ReportUtils { private static class FileFilterOnlyXmlFile implements FilenameFilter { + @Override public boolean accept(File dir, String name) { return name.startsWith("BUILD-") && name.endsWith(".xml"); } diff --git a/src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java b/src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java index 4d4c3e4..3b68f08 100644 --- a/src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java +++ b/src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java @@ -97,6 +97,7 @@ public class VerifyMojo extends AbstractMojo { * @throws org.apache.maven.plugin.MojoExecutionException If the goal encountered severe errors. * @throws org.apache.maven.plugin.MojoFailureException If any of the Maven builds failed. */ + @Override public void execute() throws MojoExecutionException, MojoFailureException { if (skipInvocation) { getLog().info("Skipping invocation per configuration."
