Author: jdcasey Date: Mon Jul 28 13:26:58 2008 New Revision: 680482 URL: http://svn.apache.org/viewvc?rev=680482&view=rev Log: Merging from 680477 on 2.0.10-RC branch, for MNG-2739.
Modified: maven/artifact/trunk/ (props changed) maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java Propchange: maven/artifact/trunk/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Jul 28 13:26:58 2008 @@ -1,2 +1,3 @@ +/maven/components/branches/maven-2.0.10-RC/maven-artifact-manager:680477 /maven/components/branches/maven-2.0.x/maven-artifact:679206 /maven/components/branches/maven-2.0.x/maven-artifact-manager:679206 Modified: maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java URL: http://svn.apache.org/viewvc/maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java?rev=680482&r1=680481&r2=680482&view=diff ============================================================================== --- maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java (original) +++ maven/artifact/trunk/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java Mon Jul 28 13:26:58 2008 @@ -87,6 +87,8 @@ private static final String MAVEN_ARTIFACT_PROPERTIES = "META-INF/maven/org.apache.maven.artifact/maven-artifact/pom.properties"; + private static int anonymousMirrorIdSeed = 0; + private PlexusContainer container; // TODO: proxies, authentication and mirrors are via settings, and should come in via an alternate method - perhaps @@ -126,7 +128,7 @@ private UpdateCheckManager updateCheckManager; private String httpUserAgent; - + // TODO: this leaks the component in the public api - it is never released back to the container public Wagon getWagon( Repository repository ) throws UnsupportedProtocolException, WagonConfigurationException @@ -1085,6 +1087,12 @@ String mirrorOf, String url ) { + if ( id == null ) + { + id = "mirror-" + anonymousMirrorIdSeed++; + getLogger().warn( "You are using a mirror that doesn't declare an <id/> element. Using \'" + id + "\' instead:\nId: " + id + "\nmirrorOf: " + mirrorOf + "\nurl: " + url + "\n" ); + } + ArtifactRepository mirror = new DefaultArtifactRepository( id, url, null ); mirrors.put( mirrorOf, mirror ); Modified: maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java URL: http://svn.apache.org/viewvc/maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java?rev=680482&r1=680481&r2=680482&view=diff ============================================================================== --- maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java (original) +++ maven/artifact/trunk/src/test/java/org/apache/maven/artifact/manager/DefaultWagonManagerTest.java Mon Jul 28 13:26:58 2008 @@ -477,6 +477,11 @@ return artifact; } + public void testAddMirrorWithNullRepositoryId() + { + wagonManager.addMirror( null, "test", "http://www.nowhere.com/" ); + } + public void testGetArtifactSha1MissingMd5Present() throws IOException, UnsupportedProtocolException, TransferFailedException, ResourceDoesNotExistException {