Author: dennisl
Date: Mon Feb 9 14:52:44 2009
New Revision: 742542
URL: http://svn.apache.org/viewvc?rev=742542&view=rev
Log:
o Use boolean instead of String for generateClient parameter.
Modified:
maven/plugins/trunk/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java
maven/plugins/trunk/maven-ejb-plugin/src/test/java/org/apache/maven/plugin/ejb/EjbMojoTest.java
Modified:
maven/plugins/trunk/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java?rev=742542&r1=742541&r2=742542&view=diff
==============================================================================
---
maven/plugins/trunk/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java
(original)
+++
maven/plugins/trunk/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/ejb/EjbMojo.java
Mon Feb 9 14:52:44 2009
@@ -90,13 +90,11 @@
private String classifier;
/**
- * Whether the EJB client jar should be generated or not. Default
- * is false.
+ * Whether the EJB client jar should be generated or not.
*
- * @parameter
- * @todo boolean instead
+ * @parameter default-value="false"
*/
- private String generateClient = Boolean.FALSE.toString();
+ private boolean generateClient;
/**
* The files and directories to exclude from the client jar. Usage:
@@ -260,7 +258,7 @@
project.getArtifact().setFile( jarFile );
}
- if ( new Boolean( generateClient ).booleanValue() )
+ if ( generateClient )
{
getLog().info( "Building EJB client " + jarName + "-client" );
Modified:
maven/plugins/trunk/maven-ejb-plugin/src/test/java/org/apache/maven/plugin/ejb/EjbMojoTest.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-ejb-plugin/src/test/java/org/apache/maven/plugin/ejb/EjbMojoTest.java?rev=742542&r1=742541&r2=742542&view=diff
==============================================================================
---
maven/plugins/trunk/maven-ejb-plugin/src/test/java/org/apache/maven/plugin/ejb/EjbMojoTest.java
(original)
+++
maven/plugins/trunk/maven-ejb-plugin/src/test/java/org/apache/maven/plugin/ejb/EjbMojoTest.java
Mon Feb 9 14:52:44 2009
@@ -80,7 +80,7 @@
setupDefaultProject( project );
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -101,7 +101,7 @@
setupDefaultProject( project );
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
setVariableValueToObject( mojo, "classifier", "classified" );
@@ -123,7 +123,7 @@
setupDefaultProject( project );
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -144,7 +144,7 @@
setupDefaultProject( project );
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
setVariableValueToObject( mojo, "classifier", "classified" );
@@ -177,7 +177,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -214,7 +214,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -252,7 +252,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -290,7 +290,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -329,7 +329,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -369,7 +369,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "true" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.TRUE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
mojo.execute();
@@ -404,7 +404,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "2.1" );
try
@@ -440,7 +440,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "3.0" );
mojo.execute();
@@ -467,7 +467,7 @@
// start creating the environment
project.setupBuildEnvironment();
- setVariableValueToObject( mojo, "generateClient", "false" );
+ setVariableValueToObject( mojo, "generateClient", Boolean.FALSE );
setVariableValueToObject( mojo, "ejbVersion", "3.0" );
mojo.execute();
