Author: bentmann
Date: Tue Jul 13 14:37:14 2010
New Revision: 963736
URL: http://svn.apache.org/viewvc?rev=963736&view=rev
Log:
o Made code more defensive and don't assume modifiable collections
Modified:
maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Modified:
maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java?rev=963736&r1=963735&r2=963736&view=diff
==============================================================================
---
maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
(original)
+++
maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Tue Jul 13 14:37:14 2010
@@ -22,6 +22,7 @@ package org.apache.maven.plugins.help;
import java.io.IOException;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
+import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.Iterator;
@@ -587,10 +588,10 @@ public class DescribeMojo
if ( ( detail || medium ) && !minimal )
{
- append( buffer, "This plugin has " + pd.getMojos().size() + " goal"
- + ( pd.getMojos().size() > 1 ? "s" : "" ) + ":", 0 );
+ append( buffer, "This plugin has " + mojos.size() + " goal" + (
mojos.size() > 1 ? "s" : "" ) + ":", 0 );
buffer.append( "\n" );
+ mojos = new ArrayList( mojos );
PluginUtils.sortMojos( mojos );
for ( Iterator it = mojos.iterator(); it.hasNext(); )
@@ -733,6 +734,7 @@ public class DescribeMojo
return;
}
+ params = new ArrayList( params );
// TODO remove when maven-plugin-tools-api:2.4.4 is out see
PluginUtils.sortMojoParameters()
Collections.sort( params, new Comparator()
{
