Author: hboutemy
Date: Sat Jun 11 20:57:33 2011
New Revision: 1134754

URL: http://svn.apache.org/viewvc?rev=1134754&view=rev
Log:
code simplification

Modified:
    
maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java

Modified: 
maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
URL: 
http://svn.apache.org/viewvc/maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java?rev=1134754&r1=1134753&r2=1134754&view=diff
==============================================================================
--- 
maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
 (original)
+++ 
maven/shared/trunk/maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
 Sat Jun 11 20:57:33 2011
@@ -562,10 +562,7 @@ public abstract class AbstractMavenRepor
             return text;
         }
 
-        StringBuilder sb = new StringBuilder();
-        sb.append( "{" ).append( text ).append( ", " ).append( href ).append( 
"}" );
-
-        return sb.toString();
+        return '{' + text + ", " + href + '}';
     }
 
     /**
@@ -576,21 +573,23 @@ public abstract class AbstractMavenRepor
      */
     protected static String propertiesToString( Properties props )
     {
-        StringBuilder sb = new StringBuilder();
-
         if ( props == null || props.isEmpty() )
         {
-            return sb.toString();
+            return "";
         }
 
+        StringBuilder sb = new StringBuilder();
+
         for ( Iterator i = props.keySet().iterator(); i.hasNext(); )
         {
             String key = (String) i.next();
-            sb.append( key ).append( "=" ).append( props.get( key ) );
-            if ( i.hasNext() )
+
+            if ( sb.length() > 0 )
             {
                 sb.append( ", " );
             }
+
+            sb.append( key ).append( "=" ).append( props.get( key ) );
         }
 
         return sb.toString();


Reply via email to