Author: krosenvold
Date: Mon Oct 22 19:47:01 2012
New Revision: 1401050

URL: http://svn.apache.org/viewvc?rev=1401050&view=rev
Log:
Fixed findbugs issue

Modified:
    
maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java

Modified: 
maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java
URL: 
http://svn.apache.org/viewvc/maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java?rev=1401050&r1=1401049&r2=1401050&view=diff
==============================================================================
--- 
maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java
 (original)
+++ 
maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/io/FileUtils.java
 Mon Oct 22 19:47:01 2012
@@ -941,31 +941,29 @@ public class FileUtils
     private static void copyStreamToFile( @Nonnull final @WillClose 
InputStream source, @Nonnull final File destination )
         throws IOException
     {
-        //does destination directory exist ?
-        if ( destination.getParentFile() != null && 
!destination.getParentFile().exists() )
-        {
-            //noinspection ResultOfMethodCallIgnored
-            destination.getParentFile().mkdirs();
-        }
-
-        //make sure we can write to destination
-        if ( destination.exists() && !destination.canWrite() )
-        {
-            final String message = "Unable to open file " + destination + " 
for writing.";
-            throw new IOException( message );
-        }
-
-        InputStream input = null;
         FileOutputStream output = null;
         try
         {
-            input = source;
+            //does destination directory exist ?
+            if ( destination.getParentFile() != null && 
!destination.getParentFile().exists() )
+            {
+                //noinspection ResultOfMethodCallIgnored
+                destination.getParentFile().mkdirs();
+            }
+
+            //make sure we can write to destination
+            if ( destination.exists() && !destination.canWrite() )
+            {
+                final String message = "Unable to open file " + destination + 
" for writing.";
+                throw new IOException( message );
+            }
+
             output = new FileOutputStream( destination );
-            IOUtil.copy( input, output );
+            IOUtil.copy( source, output );
         }
         finally
         {
-            IOUtil.close( input );
+            IOUtil.close( source );
             IOUtil.close( output );
         }
     }


Reply via email to