svn commit: r1589261 - /maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java

[mfriedenhagen]

Author: mfriedenhagen
Date: Tue Apr 22 19:34:38 2014
New Revision: 1589261

URL: http://svn.apache.org/r1589261
Log:
Close JarInputStream and FileInputStream after usage.

Otherwise a lot of open files hang around, which might lead to resource leaks
and maybe slow down processing.

Modified:
    
maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java

Modified: 
maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java
URL: 
http://svn.apache.org/viewvc/maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java?rev=1589261&r1=1589260&r2=1589261&view=diff
==============================================================================
--- 
maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java
 (original)
+++ 
maven/shared/trunk/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java
 Tue Apr 22 19:34:38 2014
@@ -94,20 +94,24 @@ public final class ClassFileVisitorUtils
         throws IOException
     {
         JarInputStream in = new JarInputStream( url.openStream() );
-
-        JarEntry entry = null;
-
-        while ( ( entry = in.getNextJarEntry() ) != null )
+        try
         {
-            String name = entry.getName();
+            JarEntry entry = null;
 
-            if ( name.endsWith( ".class" ) )
+            while ( ( entry = in.getNextJarEntry() ) != null )
             {
-                visitClass( name, in, visitor );
+                String name = entry.getName();
+
+                if ( name.endsWith( ".class" ) )
+                {
+                    visitClass( name, in, visitor );
+                }
             }
         }
-
-        in.close();
+        finally
+        {
+            in.close();
+        }
     }
 
     private static void acceptDirectory( File directory, ClassFileVisitor 
visitor )
@@ -134,9 +138,14 @@ public final class ClassFileVisitorUtils
             File file = new File( directory, path );
             FileInputStream in = new FileInputStream( file );
 
-            visitClass( path, in, visitor );
-
-            in.close();
+            try
+            {
+                visitClass( path, in, visitor );
+            }
+            finally
+            {
+                in.close();
+            }
         }
     }