Author: khmarbaise
Date: Sat May 21 11:09:29 2016
New Revision: 1744901
URL: http://svn.apache.org/viewvc?rev=1744901&view=rev
Log:
Added comment about throwing MavenFilteringException in case
of MavenSession being null.
Modified:
maven/shared/trunk/maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
Modified:
maven/shared/trunk/maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
URL:
http://svn.apache.org/viewvc/maven/shared/trunk/maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java?rev=1744901&r1=1744900&r2=1744901&view=diff
==============================================================================
---
maven/shared/trunk/maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
(original)
+++
maven/shared/trunk/maven-filtering/src/main/java/org/apache/maven/shared/filtering/BaseFilter.java
Sat May 21 11:09:29 2016
@@ -101,6 +101,15 @@ class BaseFilter
}
// TODO this is NPE free but do we consider this as normal
// or do we have to throw an MavenFilteringException with mavenSession
cannot be null
+ //
+ // khmarbaise: 2016-05-21:
+ // If we throw an MavenFilteringException tests will fail which is
+ // caused by for example:
+ // void copyFile( File from, final File to, boolean filtering,
List<FileUtils.FilterWrapper> filterWrappers, String encoding )
+ // in MavenFileFilter interface where no MavenSession is given.
+ // So changing here to throw a MavenFilteringException would make
+ // it necessary to change the interface or we need to find a better
solution.
+ //
if ( request.getMavenSession() != null )
{
// User properties have precedence over system properties
