[maven-javadoc-plugin] branch master updated: fix some its.. disable a test which need network access which is wrong

[olamy]

This is an automated email from the ASF dual-hosted git repository.

olamy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-javadoc-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 5bbfc89  fix some its.. disable a test which need network access which 
is wrong
5bbfc89 is described below

commit 5bbfc89d9bc047293329a77efbc98e87374403bd
Author: olivier lamy <ol...@apache.org>
AuthorDate: Fri Jun 14 18:26:43 2019 +1000

    fix some its.. disable a test which need network access which is wrong
    
    Signed-off-by: olivier lamy <ol...@apache.org>
---
 src/it/projects/MJAVADOC-325/invoker.properties                       | 2 +-
 src/it/projects/MJAVADOC-325/pom.xml                                  | 1 -
 src/it/projects/MJAVADOC-575_source8-module-info/pom.xml              | 1 +
 src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java | 4 ++++
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/it/projects/MJAVADOC-325/invoker.properties 
b/src/it/projects/MJAVADOC-325/invoker.properties
index abb74d6..f5fcc97 100644
--- a/src/it/projects/MJAVADOC-325/invoker.properties
+++ b/src/it/projects/MJAVADOC-325/invoker.properties
@@ -19,4 +19,4 @@ invoker.goals=clean javadoc:javadoc
 # Javadoc 12+ fails: 
 # The code being documented uses modules but the packages defined in 
https://docs.oracle.com/javase/1.5.0/docs/api/ are in the unnamed module.
 # Unrelated to the issue
-invoker.java.version= 12-
\ No newline at end of file
+invoker.java.version= 11-
diff --git a/src/it/projects/MJAVADOC-325/pom.xml 
b/src/it/projects/MJAVADOC-325/pom.xml
index ace44d0..86a9a76 100644
--- a/src/it/projects/MJAVADOC-325/pom.xml
+++ b/src/it/projects/MJAVADOC-325/pom.xml
@@ -52,5 +52,4 @@
       </plugins>
     </pluginManagement>
   </build>
-  
 </project>
diff --git a/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml 
b/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml
index 85ae725..68ed8e2 100644
--- a/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml
+++ b/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml
@@ -66,6 +66,7 @@
         </executions>
         <configuration>
           <source>8</source>
+          <detectJavaApiLink>false</detectJavaApiLink>
         </configuration>
       </plugin>
     </plugins>
diff --git 
a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java 
b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java
index 4861bb7..55bb3d6 100644
--- a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java
+++ b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java
@@ -57,6 +57,7 @@ import org.codehaus.plexus.languages.java.version.JavaVersion;
 import org.codehaus.plexus.util.FileUtils;
 import org.codehaus.plexus.util.StringUtils;
 import org.junit.AssumptionViolatedException;
+import org.junit.Ignore;
 import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager;
 
 /**
@@ -920,9 +921,12 @@ public class JavadocReportTest
      *
      * @throws Exception if any
      */
+    @Ignore("We don't really want to have unit test which need internet 
access")
     public void testProxy()
         throws Exception
     {
+        // ignore test as annotation doesn't ignore anything..
+        if(true) return;
         Settings settings = new Settings();
         Proxy proxy = new Proxy();