This is an automated email from the ASF dual-hosted git repository. rfscholte pushed a commit to branch MNG-6713 in repository https://gitbox.apache.org/repos/asf/maven.git
commit 456c50e71f6150ee8836e5534c432dc7d9829357 Author: Ray Tsang <[email protected]> AuthorDate: Mon Aug 5 12:48:16 2019 -0700 Moved `*` to a constant --- .../maven/artifact/resolver/filter/ExclusionArtifactFilter.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java b/maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java index fae069b..e0c9994 100644 --- a/maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java +++ b/maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java @@ -29,6 +29,8 @@ import java.util.List; */ public class ExclusionArtifactFilter implements ArtifactFilter { + private static final String WILDCARD = "*"; + private final List<Exclusion> exclusions; public ExclusionArtifactFilter( List<Exclusion> exclusions ) @@ -41,15 +43,15 @@ public class ExclusionArtifactFilter implements ArtifactFilter { for ( Exclusion exclusion : exclusions ) { - if ( "*".equals( exclusion.getGroupId() ) && "*".equals( exclusion.getArtifactId() ) ) + if ( WILDCARD.equals( exclusion.getGroupId() ) && WILDCARD.equals( exclusion.getArtifactId() ) ) { return false; } - if ( "*".equals( exclusion.getGroupId() ) ) + if ( WILDCARD.equals( exclusion.getGroupId() ) ) { return !exclusion.getArtifactId().equals( artifact.getArtifactId() ); } - if ( "*".equals( exclusion.getArtifactId() ) ) + if ( WILDCARD.equals( exclusion.getArtifactId() ) ) { return !exclusion.getGroupId().equals( artifact.getGroupId() ); }
