[maven-plugin-tools] branch master updated: Add missing @Override and make methods static

[tibordigana]

This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-plugin-tools.git


The following commit(s) were added to refs/heads/master by this push:
     new 8430e4a  Add missing @Override and make methods static
8430e4a is described below

commit 8430e4a216b133d7467afde8e67302223c9840c7
Author: Andrew Gaul <and...@gaul.org>
AuthorDate: Sun Oct 28 00:04:05 2018 -0700

    Add missing @Override and make methods static
    
    Found via error-prone.
---
 .../src/main/resources/help-class-source.vm                   | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git 
a/maven-plugin-tools-generators/src/main/resources/help-class-source.vm 
b/maven-plugin-tools-generators/src/main/resources/help-class-source.vm
index 4e733fe..eeafb3e 100644
--- a/maven-plugin-tools-generators/src/main/resources/help-class-source.vm
+++ b/maven-plugin-tools-generators/src/main/resources/help-class-source.vm
@@ -153,6 +153,7 @@ public class HelpMojo
     /**
      * {@inheritDoc}
      */
+    @Override
     public void execute()
         throws MojoExecutionException
     {
@@ -224,13 +225,13 @@ public class HelpMojo
         return string != null && string.length() > 0;
     }
 
-    private String getValue( Node node, String elementName )
+    private static String getValue( Node node, String elementName )
         throws MojoExecutionException
     {
         return getSingleChild( node, elementName ).getTextContent();
     }
 
-    private Node getSingleChild( Node node, String elementName )
+    private static Node getSingleChild( Node node, String elementName )
         throws MojoExecutionException
     {
         List<Node> namedChild = findNamedChild( node, elementName );
@@ -245,7 +246,7 @@ public class HelpMojo
         return namedChild.get( 0 );
     }
 
-    private List<Node> findNamedChild( Node node, String elementName )
+    private static List<Node> findNamedChild( Node node, String elementName )
     {
         List<Node> result = new ArrayList<Node>();
         NodeList childNodes = node.getChildNodes();
@@ -260,7 +261,7 @@ public class HelpMojo
         return result;
     }
 
-    private Node findSingleChild( Node node, String elementName )
+    private static Node findSingleChild( Node node, String elementName )
         throws MojoExecutionException
     {
         List<Node> elementsByTagName = findNamedChild( node, elementName );
@@ -491,7 +492,7 @@ public class HelpMojo
         return level;
     }
     
-    private String getPropertyFromExpression( String expression )
+    private static String getPropertyFromExpression( String expression )
     {
         if ( expression != null && expression.startsWith( "${" ) && 
expression.endsWith( "}" )
             && !expression.substring( 2 ).contains( "${" ) )