This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch maven-3.8.x
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/maven-3.8.x by this push:
     new 8b693cc  Document hacks as such
8b693cc is described below

commit 8b693cc992ff4a5947babecd222fbebf7516e677
Author: Michael Osipov <[email protected]>
AuthorDate: Fri Jul 2 17:50:44 2021 +0200

    Document hacks as such
---
 .../main/java/org/apache/maven/project/artifact/MavenMetadataSource.java | 1 +
 .../maven/repository/internal/DefaultArtifactDescriptorReader.java       | 1 +
 2 files changed, 2 insertions(+)

diff --git 
a/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
 
b/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
index 1c40af8..ac55fb9 100644
--- 
a/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
+++ 
b/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java
@@ -180,6 +180,7 @@ public class MavenMetadataSource
 
         Artifact relocatedArtifact = null;
 
+        // TODO hack: don't rebuild model if it was already loaded during 
reactor resolution
         final WorkspaceReader workspace = 
legacySupport.getRepositorySession().getWorkspaceReader();
         Model model = null;
         if ( workspace instanceof MavenWorkspaceReader )
diff --git 
a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
 
b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
index 586c83e..c2ba0a3 100644
--- 
a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
+++ 
b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
@@ -257,6 +257,7 @@ public class DefaultArtifactDescriptorReader
 
             Model model;
 
+            // TODO hack: don't rebuild model if it was already loaded during 
reactor resolution
             final WorkspaceReader workspace = session.getWorkspaceReader();
             if ( workspace instanceof MavenWorkspaceReader )
             {

Reply via email to