This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch MCOMPILER-398
in repository https://gitbox.apache.org/repos/asf/maven-compiler-plugin.git

commit 0a0cbcaf8c64e738c2e9cef36c473cbd3bb0c232
Author: Russell Howe <[email protected]>
AuthorDate: Mon Sep 23 08:54:06 2019 +0100

    Simplify CompilerMojo's getSourceInclusionScanner
    
    Make the flow through this method clearer.
---
 .../org/apache/maven/plugin/compiler/CompilerMojo.java    | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java 
b/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java
index 4df2dd0..6598253 100644
--- a/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java
+++ b/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java
@@ -361,22 +361,17 @@ public class CompilerMojo
     
     protected SourceInclusionScanner getSourceInclusionScanner( int 
staleMillis )
     {
-        SourceInclusionScanner scanner;
-
         if ( includes.isEmpty() && excludes.isEmpty() )
         {
-            scanner = new StaleSourceScanner( staleMillis );
+            return new StaleSourceScanner( staleMillis );
         }
-        else
+
+        if ( includes.isEmpty() )
         {
-            if ( includes.isEmpty() )
-            {
-                includes.add( "**/*.java" );
-            }
-            scanner = new StaleSourceScanner( staleMillis, includes, excludes 
);
+            includes.add( "**/*.java" );
         }
 
-        return scanner;
+        return new StaleSourceScanner( staleMillis, includes, excludes );
     }
 
     protected SourceInclusionScanner getSourceInclusionScanner( String 
inputFileEnding )

Reply via email to