This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-invoker-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 25cce6d  Use String#join instead of manual joining
25cce6d is described below

commit 25cce6d20e004554ea1b1cfd4ce87627e1fa99af
Author: Slawomir Jaranowski <[email protected]>
AuthorDate: Fri Dec 10 16:32:17 2021 +0100

    Use String#join instead of manual joining
---
 .../maven/plugins/invoker/AbstractInvokerMojo.java | 26 +++++++---------------
 1 file changed, 8 insertions(+), 18 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java 
b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
index 2228acf..2e11984 100644
--- a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
+++ b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
@@ -1721,43 +1721,33 @@ public abstract class AbstractInvokerMojo
             {
                 buildJob.setResult( BuildJob.Result.SKIPPED );
 
-                StringBuilder message = new StringBuilder();
+                List<String> messages = new ArrayList<>();
+
                 if ( selection == Selector.SELECTOR_MULTI )
                 {
-                    message.append( "non-matching selectors" );
+                    messages.add( "non-matching selectors" );
                 }
                 else
                 {
                     if ( ( selection & Selector.SELECTOR_MAVENVERSION ) != 0 )
                     {
-                        message.append( "Maven version" );
+                        messages.add( "Maven version" );
                     }
                     if ( ( selection & Selector.SELECTOR_JREVERSION ) != 0 )
                     {
-                        if ( message.length() > 0 )
-                        {
-                            message.append( ", " );
-                        }
-                        message.append( "JRE version" );
+                        messages.add( "JRE version" );
                     }
                     if ( ( selection & Selector.SELECTOR_OSFAMILY ) != 0 )
                     {
-                        if ( message.length() > 0 )
-                        {
-                            message.append( ", " );
-                        }
-                        message.append( "OS" );
+                        messages.add( "OS" );
                     }
                     if ( ( selection & Selector.SELECTOR_TOOLCHAIN ) != 0 )
                     {
-                        if ( message.length() > 0 )
-                        {
-                            message.append( ", " );
-                        }
-                        message.append( "Toolchain" );
+                        messages.add( "Toolchain" );
                     }
                 }
 
+                String message = String.join( ", ", messages );
                 if ( !suppressSummaries )
                 {
                     getLog().info( pad( buildJob ).warning( "SKIPPED" ) + " 
due to " + message );

Reply via email to