This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new d8445a5 Improve PR template
d8445a5 is described below
commit d8445a54bb4a7f7b223afe5bd8ee06bd31e50cf4
Author: Michael Osipov <[email protected]>
AuthorDate: Thu Dec 30 14:52:36 2021 +0100
Improve PR template
---
.github/pull_request_template.md | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 2208cd7..b4a4f83 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -1,17 +1,16 @@
-Following this checklist to help us incorporate your
+Following this checklist to help us incorporate your
contribution quickly and easily:
- - [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
- for the change (usually before you start working on it). Trivial
changes like typos do not
- require a JIRA issue. Your pull request should address just this
issue, without
+ - [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
+ for the change (usually before you start working on it). Trivial
changes like typos do not
+ require a JIRA issue. Your pull request should address just this issue,
without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`,
- where you replace `MNG-XXX` with the appropriate JIRA issue. Best
practice
- is to use the JIRA issue title in the pull request title and in the
first line of the
- commit message.
+ - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
+ and `SUMMARY` with the appropriate JIRA issue. Best practice is to use
the JIRA issue
+ title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough
check will
+ - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough
check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
@@ -19,7 +18,7 @@ If your pull request is about ~20 lines of code you don't
need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
-To make clear that you license your contribution under
+To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
