[maven-invoker] branch master updated: [MSHARED-1012] Improve error for invalid Maven home

[sjaranowski]

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-invoker.git


The following commit(s) were added to refs/heads/master by this push:
     new 246bf9e  [MSHARED-1012] Improve error for invalid Maven home
246bf9e is described below

commit 246bf9e0ce1fb1dc491e0fc75479638cfae17216
Author: Slawomir Jaranowski <s.jaranow...@gmail.com>
AuthorDate: Fri Dec 31 11:23:57 2021 +0100

    [MSHARED-1012] Improve error for invalid Maven home
---
 .../java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java | 4 ++--
 .../org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java  | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java 
b/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
index 186da75..a6e33fe 100644
--- a/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
+++ b/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
@@ -560,7 +560,7 @@ public class MavenCommandLineBuilder
 
     }
 
-    void setupMavenHome( InvocationRequest request )
+    private void setupMavenHome( InvocationRequest request )
     {
         if ( request.getMavenHome() != null )
         {
@@ -584,7 +584,7 @@ public class MavenCommandLineBuilder
 
         if ( mavenHome != null && !mavenHome.isDirectory() )
         {
-            throw new IllegalStateException( "maven home is not specified as a 
directory: '" + mavenHome + "'." );
+            throw new IllegalStateException( "Maven home is set to: '" + 
mavenHome + "' which is not a directory" );
         }
 
         logger.debug( "Using maven.home of: '" + mavenHome + "'." );
diff --git 
a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
 
b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
index 9e96652..f019255 100644
--- 
a/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
+++ 
b/src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java
@@ -33,7 +33,6 @@ import java.util.Set;
 import org.apache.maven.shared.utils.Os;
 import org.apache.maven.shared.utils.cli.Commandline;
 import org.junit.After;
-import org.junit.Assume;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
@@ -46,7 +45,6 @@ import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.junit.Assume.assumeThat;
-import static org.junit.Assume.assumeTrue;
 
 public class MavenCommandLineBuilderTest
 {