Updated Branches: refs/heads/master f45214ab8 -> 251656f77
Added a note about the reliability of kill task requests. Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/251656f7 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/251656f7 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/251656f7 Branch: refs/heads/master Commit: 251656f77927fc294703019717bb9d3367134def Parents: 2e45578 Author: Benjamin Mahler <[email protected]> Authored: Tue Nov 12 15:49:34 2013 -0800 Committer: Benjamin Mahler <[email protected]> Committed: Tue Nov 12 15:50:06 2013 -0800 ---------------------------------------------------------------------- include/mesos/scheduler.hpp | 3 ++- src/java/src/org/apache/mesos/SchedulerDriver.java | 3 ++- src/python/src/mesos.py | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/251656f7/include/mesos/scheduler.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/scheduler.hpp b/include/mesos/scheduler.hpp index fa1ffe8..380e087 100644 --- a/include/mesos/scheduler.hpp +++ b/include/mesos/scheduler.hpp @@ -253,7 +253,8 @@ public: * Kills the specified task. Note that attempting to kill a task is * currently not reliable. If, for example, a scheduler fails over * while it was attempting to kill a task it will need to retry in - * the future (these semantics may be changed in the future). + * the future. Likewise, if unregistered / disconnected, the request + * will be dropped (these semantics may be changed in the future). */ virtual Status killTask(const TaskID& taskId) = 0; http://git-wip-us.apache.org/repos/asf/mesos/blob/251656f7/src/java/src/org/apache/mesos/SchedulerDriver.java ---------------------------------------------------------------------- diff --git a/src/java/src/org/apache/mesos/SchedulerDriver.java b/src/java/src/org/apache/mesos/SchedulerDriver.java index 93aaa54..5b0ca39 100644 --- a/src/java/src/org/apache/mesos/SchedulerDriver.java +++ b/src/java/src/org/apache/mesos/SchedulerDriver.java @@ -109,7 +109,8 @@ public interface SchedulerDriver { * Kills the specified task. Note that attempting to kill a task is * currently not reliable. If, for example, a scheduler fails over * while it was attempting to kill a task it will need to retry in - * the future (these semantics may be changed in the future). + * the future Likewise, if unregistered / disconnected, the request + * will be dropped (these semantics may be changed in the future). */ Status killTask(TaskID taskId); http://git-wip-us.apache.org/repos/asf/mesos/blob/251656f7/src/python/src/mesos.py ---------------------------------------------------------------------- diff --git a/src/python/src/mesos.py b/src/python/src/mesos.py index 546a07a..a2fc0e9 100644 --- a/src/python/src/mesos.py +++ b/src/python/src/mesos.py @@ -207,8 +207,9 @@ class SchedulerDriver(object): """ Kills the specified task. Note that attempting to kill a task is currently not reliable. If, for example, a scheduler fails over while - it was attempting to kill a task it will need to retry in the future - (these semantics may be changed in the future). + it was attempting to kill a task it will need to retry in the future. + Likewise, if unregistered / disconnected, the request will be dropped + dropped (these semantics may be changed in the future). """ def declineOffer(self, offerId, filters=None):
