Repository: mesos Updated Branches: refs/heads/master bcec2ae36 -> 7deccdbdc
Added a flag to review bot to specify number of reviews to verify. Review: https://reviews.apache.org/r/18827 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/7deccdbd Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/7deccdbd Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/7deccdbd Branch: refs/heads/master Commit: 7deccdbdc111886509e46406e8d41e13bdc99d31 Parents: bcec2ae Author: Vinod Kone <[email protected]> Authored: Wed Mar 5 17:16:11 2014 -0800 Committer: Vinod Kone <[email protected]> Committed: Wed Mar 5 17:16:11 2014 -0800 ---------------------------------------------------------------------- support/verify-reviews.py | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/7deccdbd/support/verify-reviews.py ---------------------------------------------------------------------- diff --git a/support/verify-reviews.py b/support/verify-reviews.py index 37e30a3..1761579 100755 --- a/support/verify-reviews.py +++ b/support/verify-reviews.py @@ -14,22 +14,28 @@ from datetime import datetime, timedelta REVIEWBOARD_URL = "https://reviews.apache.org"; +# TODO(vinod): Use 'argparse' module. # Get the user and password from command line. if len(sys.argv) < 3: - print "Usage: ./verify-reviews.py <user> <password> [query-params]" + print "Usage: ./verify-reviews.py <user> <password> [num-reviews] [query-params]" sys.exit(1) USER = sys.argv[1] PASSWORD = sys.argv[2] +# Number of reviews to verify. +NUM_REVIEWS = -1 # All possible reviews. +if len(sys.argv) >= 4: + NUM_REVIEWS = int(sys.argv[3]) + # Unless otherwise specified consider pending review requests to Mesos updated # since 03/01/2014. GROUP = "mesos" LAST_UPDATED = "2014-03-01T00:00:00" QUERY_PARAMS = "?to-groups=%s&status=pending&last-updated-from=%s" \ % (GROUP, LAST_UPDATED) -if len(sys.argv) >= 4: - QUERY_PARAMS = sys.argv[3] +if len(sys.argv) >= 5: + QUERY_PARAMS = sys.argv[4] def shell(command): @@ -164,6 +170,9 @@ if __name__=="__main__": review_requests_url = "%s/api/review-requests/%s" % (REVIEWBOARD_URL, QUERY_PARAMS) review_requests = api(review_requests_url) + num_reviews = 0 for review_request in review_requests["review_requests"]: - if needs_verification(review_request): + if (NUM_REVIEWS == -1 or num_reviews < NUM_REVIEWS) and \ + needs_verification(review_request): verify_review(review_request) + num_reviews += 1
