Repository: mesos Updated Branches: refs/heads/master d1da7efd6 -> bc0028d66
Add explicit to single argument constructors in libprocess. Applied either "explicit" or "/*implicit*/" to all single-arg constructors in lib process that do not take the constructed type as parameter. Sorted out which denotation to choose by compiling mess and fixing all the compile errors and by estimating whether implicit conversions might be intended by the original authors. Review: https://reviews.apache.org/r/19086 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/bc0028d6 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/bc0028d6 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/bc0028d6 Branch: refs/heads/master Commit: bc0028d6643b68c0ab7ef19a191d024faebb8d2c Parents: d1da7ef Author: Bernd Mathiske <be...@mesosphere.io> Authored: Thu Mar 27 10:47:18 2014 -0700 Committer: Jie Yu <yujie....@gmail.com> Committed: Thu Mar 27 10:48:13 2014 -0700 ---------------------------------------------------------------------- .../libprocess/include/process/c++11/deferred.hpp | 5 +++-- 3rdparty/libprocess/include/process/deferred.hpp | 5 +++-- 3rdparty/libprocess/include/process/event.hpp | 10 +++++----- 3rdparty/libprocess/include/process/future.hpp | 16 ++++++++-------- 3rdparty/libprocess/include/process/http.hpp | 16 ++++++++-------- 3rdparty/libprocess/include/process/owned.hpp | 2 +- 3rdparty/libprocess/include/process/pid.hpp | 10 +++++----- 3rdparty/libprocess/include/process/process.hpp | 2 +- 3rdparty/libprocess/include/process/shared.hpp | 2 +- 3rdparty/libprocess/include/process/time.hpp | 2 +- 3rdparty/libprocess/include/process/timeout.hpp | 2 +- .../libprocess/include/process/tuples/details.hpp | 4 ++-- .../libprocess/include/process/tuples/tuples.hpp | 4 ++-- 3rdparty/libprocess/src/decoder.hpp | 2 +- 3rdparty/libprocess/src/encoder.hpp | 2 +- 3rdparty/libprocess/src/httpd.cpp | 2 +- 3rdparty/libprocess/src/net.hpp | 4 ++-- 3rdparty/libprocess/src/process.cpp | 10 +++++----- 3rdparty/libprocess/src/synchronized.hpp | 2 +- 3rdparty/libprocess/src/test-slave.cpp | 2 +- 3rdparty/libprocess/src/tests/encoder_tests.cpp | 2 +- 3rdparty/libprocess/src/tests/process_tests.cpp | 6 +++--- 22 files changed, 57 insertions(+), 55 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/c++11/deferred.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/c++11/deferred.hpp b/3rdparty/libprocess/include/process/c++11/deferred.hpp index 57a3df5..4a25e12 100644 --- a/3rdparty/libprocess/include/process/c++11/deferred.hpp +++ b/3rdparty/libprocess/include/process/c++11/deferred.hpp @@ -35,7 +35,7 @@ private: friend Deferred<Future<R>(void)> defer(const PID<T>& pid, R (T::*method)(void)); - Deferred(const std::function<F>& f) : std::function<F>(f) {} + /*implicit*/ Deferred(const std::function<F>& f) : std::function<F>(f) {} }; @@ -258,7 +258,8 @@ private: #undef TEMPLATE _Deferred(const UPID& pid, F f) : pid(pid), f(f) {} - _Deferred(F f) : f(f) {} + + /*implicit*/ _Deferred(F f) : f(f) {} Option<UPID> pid; F f; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/deferred.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/deferred.hpp b/3rdparty/libprocess/include/process/deferred.hpp index c18619e..0552fb5 100644 --- a/3rdparty/libprocess/include/process/deferred.hpp +++ b/3rdparty/libprocess/include/process/deferred.hpp @@ -45,7 +45,8 @@ private: REPEAT_FROM_TO(1, 11, TEMPLATE, _) // Args A0 -> A9. #undef TEMPLATE - Deferred(const std::tr1::function<F>& f) : std::tr1::function<F>(f) {} + /*implicit*/ Deferred(const std::tr1::function<F>& f) + : std::tr1::function<F>(f) {} }; @@ -134,7 +135,7 @@ private: REPEAT_FROM_TO(1, 11, TEMPLATE, _) // Args A0 -> A9. #undef TEMPLATE - _Defer(const std::tr1::_Bind<F>& b) + /*implicit*/ _Defer(const std::tr1::_Bind<F>& b) : std::tr1::_Bind<F>(b) {} }; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/event.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/event.hpp b/3rdparty/libprocess/include/process/event.hpp index ca407ec..e30a4d4 100644 --- a/3rdparty/libprocess/include/process/event.hpp +++ b/3rdparty/libprocess/include/process/event.hpp @@ -43,7 +43,7 @@ struct Event bool result = false; struct IsVisitor : EventVisitor { - IsVisitor(bool* _result) : result(_result) {} + explicit IsVisitor(bool* _result) : result(_result) {} virtual void visit(const T& t) { *result = true; } bool* result; } visitor(&result); @@ -57,7 +57,7 @@ struct Event const T* result = NULL; struct AsVisitor : EventVisitor { - AsVisitor(const T** _result) : result(_result) {} + explicit AsVisitor(const T** _result) : result(_result) {} virtual void visit(const T& t) { *result = &t; } const T** result; } visitor(&result); @@ -73,7 +73,7 @@ struct Event struct MessageEvent : Event { - MessageEvent(Message* _message) + explicit MessageEvent(Message* _message) : message(_message) {} virtual ~MessageEvent() @@ -159,7 +159,7 @@ private: struct ExitedEvent : Event { - ExitedEvent(const UPID& _pid) + explicit ExitedEvent(const UPID& _pid) : pid(_pid) {} virtual void visit(EventVisitor* visitor) const @@ -178,7 +178,7 @@ private: struct TerminateEvent : Event { - TerminateEvent(const UPID& _from) + explicit TerminateEvent(const UPID& _from) : from(_from) {} virtual void visit(EventVisitor* visitor) const http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/future.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp index 0be4af0..37c04c3 100644 --- a/3rdparty/libprocess/include/process/future.hpp +++ b/3rdparty/libprocess/include/process/future.hpp @@ -86,14 +86,14 @@ public: Future(); - Future(const T& _t); + /*implicit*/ Future(const T& _t); template <typename U> - Future(const U& u); + /*implicit*/ Future(const U& u); - Future(const Failure& failure); + /*implicit*/ Future(const Failure& failure); - Future(const Future<T>& that); + /*implicit*/ Future(const Future<T>& that); ~Future(); @@ -557,7 +557,7 @@ template <typename T> class WeakFuture { public: - WeakFuture(const Future<T>& future); + explicit WeakFuture(const Future<T>& future); // Converts this weak reference to a concrete future. Returns none // if the conversion is not successful. @@ -590,8 +590,8 @@ Option<Future<T> > WeakFuture<T>::get() // Helper for creating failed futures. struct Failure { - Failure(const std::string& _message) : message(_message) {} - Failure(const Error& error) : message(error.message) {} + explicit Failure(const std::string& _message) : message(_message) {} + explicit Failure(const Error& error) : message(error.message) {} const std::string message; }; @@ -610,7 +610,7 @@ class Promise { public: Promise(); - Promise(const T& t); + explicit Promise(const T& t); virtual ~Promise(); bool discard(); http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/http.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/http.hpp b/3rdparty/libprocess/include/process/http.hpp index 15bd8a1..f85c065 100644 --- a/3rdparty/libprocess/include/process/http.hpp +++ b/3rdparty/libprocess/include/process/http.hpp @@ -119,7 +119,7 @@ struct Response : type(NONE) {} - Response(const std::string& _body) + explicit Response(const std::string& _body) : type(BODY), body(_body) { @@ -172,12 +172,12 @@ struct OK : Response status = "200 OK"; } - OK(const char* body) : Response(std::string(body)) + explicit OK(const char* body) : Response(std::string(body)) { status = "200 OK"; } - OK(const std::string& body) : Response(body) + explicit OK(const std::string& body) : Response(body) { status = "200 OK"; } @@ -211,7 +211,7 @@ struct OK : Response struct TemporaryRedirect : Response { - TemporaryRedirect(const std::string& url) + explicit TemporaryRedirect(const std::string& url) { status = "307 Temporary Redirect"; headers["Location"] = url; @@ -226,7 +226,7 @@ struct BadRequest : Response status = "400 Bad Request"; } - BadRequest(const std::string& body) + explicit BadRequest(const std::string& body) : Response(body) { status = "400 Bad Request"; @@ -241,7 +241,7 @@ struct NotFound : Response status = "404 Not Found"; } - NotFound(const std::string& body) : Response(body) + explicit NotFound(const std::string& body) : Response(body) { status = "404 Not Found"; } @@ -255,7 +255,7 @@ struct InternalServerError : Response status = "500 Internal Server Error"; } - InternalServerError(const std::string& body) : Response(body) + explicit InternalServerError(const std::string& body) : Response(body) { status = "500 Internal Server Error"; } @@ -269,7 +269,7 @@ struct ServiceUnavailable : Response status = "503 Service Unavailable"; } - ServiceUnavailable(const std::string& body) : Response(body) + explicit ServiceUnavailable(const std::string& body) : Response(body) { status = "503 Service Unavailable"; } http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/owned.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/owned.hpp b/3rdparty/libprocess/include/process/owned.hpp index 4a03ea4..66725ca 100644 --- a/3rdparty/libprocess/include/process/owned.hpp +++ b/3rdparty/libprocess/include/process/owned.hpp @@ -43,7 +43,7 @@ public: private: struct Data { - Data(T* t); + explicit Data(T* t); ~Data(); T* volatile t; // The pointer 't' is volatile. http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/pid.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/pid.hpp b/3rdparty/libprocess/include/process/pid.hpp index 5a77dbc..fbd512f 100644 --- a/3rdparty/libprocess/include/process/pid.hpp +++ b/3rdparty/libprocess/include/process/pid.hpp @@ -28,11 +28,11 @@ struct UPID UPID(const std::string& id_, uint32_t ip_, uint16_t port_) : id(id_), ip(ip_), port(port_) {} - UPID(const char* s); + /*implicit*/ UPID(const char* s); - UPID(const std::string& s); + /*implicit*/ UPID(const std::string& s); - UPID(const ProcessBase& process); + /*implicit*/ UPID(const ProcessBase& process); operator std::string () const; @@ -87,8 +87,8 @@ struct PID : UPID { PID() : UPID() {} - PID(const T* t) : UPID(static_cast<const ProcessBase&>(*t)) {} - PID(const T& t) : UPID(static_cast<const ProcessBase&>(t)) {} + /*implicit*/ PID(const T* t) : UPID(static_cast<const ProcessBase&>(*t)) {} + /*implicit*/ PID(const T& t) : UPID(static_cast<const ProcessBase&>(t)) {} template <typename Base> operator PID<Base> () const http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/process.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/process.hpp b/3rdparty/libprocess/include/process/process.hpp index 37283ea..d6bdccf 100644 --- a/3rdparty/libprocess/include/process/process.hpp +++ b/3rdparty/libprocess/include/process/process.hpp @@ -25,7 +25,7 @@ namespace process { class ProcessBase : public EventVisitor { public: - ProcessBase(const std::string& id = ""); + explicit ProcessBase(const std::string& id = ""); virtual ~ProcessBase(); http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/shared.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/shared.hpp b/3rdparty/libprocess/include/process/shared.hpp index 8f5b59b..badd6a0 100644 --- a/3rdparty/libprocess/include/process/shared.hpp +++ b/3rdparty/libprocess/include/process/shared.hpp @@ -46,7 +46,7 @@ public: private: struct Data { - Data(T* _t); + explicit Data(T* _t); ~Data(); T* t; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/time.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/time.hpp b/3rdparty/libprocess/include/process/time.hpp index bd31211..0803dc5 100644 --- a/3rdparty/libprocess/include/process/time.hpp +++ b/3rdparty/libprocess/include/process/time.hpp @@ -71,7 +71,7 @@ private: // Made it private to avoid the confusion between Time and Duration. // Users should explicitly use Clock::now() and Time::create() to // create a new time instance. - Time(const Duration& _sinceEpoch) : sinceEpoch(_sinceEpoch) {} + explicit Time(const Duration& _sinceEpoch) : sinceEpoch(_sinceEpoch) {} }; inline Time Time::epoch() { return Time(Duration::zero()); } http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/timeout.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/timeout.hpp b/3rdparty/libprocess/include/process/timeout.hpp index 4634b9f..40906cb 100644 --- a/3rdparty/libprocess/include/process/timeout.hpp +++ b/3rdparty/libprocess/include/process/timeout.hpp @@ -15,7 +15,7 @@ class Timeout public: Timeout() : timeout(Clock::now()) {} - Timeout(const Time& time) : timeout(time) {} + explicit Timeout(const Time& time) : timeout(time) {} Timeout(const Timeout& that) : timeout(that.timeout) {} http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/tuples/details.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/tuples/details.hpp b/3rdparty/libprocess/include/process/tuples/details.hpp index 34a9fb5..80b0539 100644 --- a/3rdparty/libprocess/include/process/tuples/details.hpp +++ b/3rdparty/libprocess/include/process/tuples/details.hpp @@ -8,10 +8,10 @@ template <MSGID ID> class tuple; template <> class tuple<ID> : public boost::tuple<IDENTITY types> \ { \ public: \ - tuple(const boost::tuple<IDENTITY types> &t) \ + explicit tuple(const boost::tuple<IDENTITY types> &t) \ : boost::tuple<IDENTITY types>(t) {} \ \ - tuple(const std::string &data) \ + explicit tuple(const std::string &data) \ { \ std::istringstream is(data); \ process::tuples::deserializer d(is); \ http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/include/process/tuples/tuples.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/tuples/tuples.hpp b/3rdparty/libprocess/include/process/tuples/tuples.hpp index 672ba6c..ac1198e 100644 --- a/3rdparty/libprocess/include/process/tuples/tuples.hpp +++ b/3rdparty/libprocess/include/process/tuples/tuples.hpp @@ -21,7 +21,7 @@ struct serializer { std::ostringstream& stream; - serializer(std::ostringstream& s) : stream(s) {} + explicit serializer(std::ostringstream& s) : stream(s) {} void operator & (const int32_t & i) { @@ -85,7 +85,7 @@ struct deserializer { std::istringstream &stream; - deserializer(std::istringstream &s) : stream(s) {} + explicit deserializer(std::istringstream &s) : stream(s) {} void operator & (int32_t &i) { http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/decoder.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/decoder.hpp b/3rdparty/libprocess/src/decoder.hpp index a34c005..88da57f 100644 --- a/3rdparty/libprocess/src/decoder.hpp +++ b/3rdparty/libprocess/src/decoder.hpp @@ -22,7 +22,7 @@ namespace process { class DataDecoder { public: - DataDecoder(const Socket& _s) + explicit DataDecoder(const Socket& _s) : s(_s), failure(false), request(NULL) { settings.on_message_begin = &DataDecoder::on_message_begin; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/encoder.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/encoder.hpp b/3rdparty/libprocess/src/encoder.hpp index 4810e99..7f4593b 100644 --- a/3rdparty/libprocess/src/encoder.hpp +++ b/3rdparty/libprocess/src/encoder.hpp @@ -34,7 +34,7 @@ extern void send_file(struct ev_loop*, ev_io*, int); class Encoder { public: - Encoder(const Socket& _s) : s(_s) {} + explicit Encoder(const Socket& _s) : s(_s) {} virtual ~Encoder() {} virtual Sender sender() = 0; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/httpd.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/httpd.cpp b/3rdparty/libprocess/src/httpd.cpp index bbd5251..4f4ab1b 100644 --- a/3rdparty/libprocess/src/httpd.cpp +++ b/3rdparty/libprocess/src/httpd.cpp @@ -199,7 +199,7 @@ protected: } public: - HttpConnection(int s) : SocketProcess<TCP>(s) {} + explicit HttpConnection(int s) : SocketProcess<TCP>(s) {} ~HttpConnection() {} }; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/net.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/net.hpp b/3rdparty/libprocess/src/net.hpp index 2fdc62a..f4783fd 100644 --- a/3rdparty/libprocess/src/net.hpp +++ b/3rdparty/libprocess/src/net.hpp @@ -149,7 +149,7 @@ protected: public: SocketProcess() : s(-1) {} - SocketProcess(int _s) : s(_s) + explicit SocketProcess(int _s) : s(_s) { int flags = 1; if (ioctl(s, FIONBIO, &flags) && @@ -189,7 +189,7 @@ protected: public: Acceptor() {} - Acceptor(int s) : SocketProcess<protocol>(s) {} + explicit Acceptor(int s) : SocketProcess<protocol>(s) {} }; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/process.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp index 6c6acc0..9654c04 100644 --- a/3rdparty/libprocess/src/process.cpp +++ b/3rdparty/libprocess/src/process.cpp @@ -202,7 +202,7 @@ public: private: friend class ProcessManager; // For ProcessManager::use. - ProcessReference(ProcessBase* _process) + explicit ProcessReference(ProcessBase* _process) : process(_process) { if (process != NULL) { @@ -246,7 +246,7 @@ private: class HttpProxy : public Process<HttpProxy> { public: - HttpProxy(const Socket& _socket); + explicit HttpProxy(const Socket& _socket); virtual ~HttpProxy(); // Enqueues the response to be sent once all previously enqueued @@ -421,7 +421,7 @@ private: class ProcessManager { public: - ProcessManager(const string& delegate); + explicit ProcessManager(const string& delegate); ~ProcessManager(); ProcessReference use(const UPID& pid); @@ -2569,7 +2569,7 @@ void ProcessManager::resume(ProcessBase* process) bool filter = false; struct FilterVisitor : EventVisitor { - FilterVisitor(bool* _filter) : filter(_filter) {} + explicit FilterVisitor(bool* _filter) : filter(_filter) {} virtual void visit(const MessageEvent& event) { @@ -2947,7 +2947,7 @@ Future<Response> ProcessManager::__processes__(const Request&) struct JSONVisitor : EventVisitor { - JSONVisitor(JSON::Array* _events) : events(_events) {} + explicit JSONVisitor(JSON::Array* _events) : events(_events) {} virtual void visit(const MessageEvent& event) { http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/synchronized.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/synchronized.hpp b/3rdparty/libprocess/src/synchronized.hpp index 7e0efe2..0804e5b 100644 --- a/3rdparty/libprocess/src/synchronized.hpp +++ b/3rdparty/libprocess/src/synchronized.hpp @@ -71,7 +71,7 @@ private: class Synchronized { public: - Synchronized(Synchronizable *_synchronizable) + explicit Synchronized(Synchronizable *_synchronizable) : synchronizable(_synchronizable) { synchronizable->acquire(); http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/test-slave.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/test-slave.cpp b/3rdparty/libprocess/src/test-slave.cpp index fe08ce8..cf9b52c 100644 --- a/3rdparty/libprocess/src/test-slave.cpp +++ b/3rdparty/libprocess/src/test-slave.cpp @@ -48,7 +48,7 @@ protected: } public: - Slave(const PID &_master) : master(_master) {} + explicit Slave(const PID &_master) : master(_master) {} }; http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/tests/encoder_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/tests/encoder_tests.cpp b/3rdparty/libprocess/src/tests/encoder_tests.cpp index fccb865..784a2c7 100644 --- a/3rdparty/libprocess/src/tests/encoder_tests.cpp +++ b/3rdparty/libprocess/src/tests/encoder_tests.cpp @@ -23,7 +23,7 @@ using std::vector; TEST(Encoder, Response) { Request request; - const OK& response("body"); + const OK response("body"); // Encode the response. const string& encoded = HttpResponseEncoder::encode(response, request); http://git-wip-us.apache.org/repos/asf/mesos/blob/bc0028d6/3rdparty/libprocess/src/tests/process_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/tests/process_tests.cpp b/3rdparty/libprocess/src/tests/process_tests.cpp index be9099c..9dae931 100644 --- a/3rdparty/libprocess/src/tests/process_tests.cpp +++ b/3rdparty/libprocess/src/tests/process_tests.cpp @@ -860,7 +860,7 @@ TEST(Process, thunk) class DelegatorProcess : public Process<DelegatorProcess> { public: - DelegatorProcess(const UPID& delegatee) + explicit DelegatorProcess(const UPID& delegatee) { delegate("func", delegatee); } @@ -1020,7 +1020,7 @@ TEST(Process, donate) class ExitedProcess : public Process<ExitedProcess> { public: - ExitedProcess(const UPID& pid) { link(pid); } + explicit ExitedProcess(const UPID& pid) { link(pid); } MOCK_METHOD1(exited, void(const UPID&)); }; @@ -1502,7 +1502,7 @@ TEST(Process, limiter) class FileServer : public Process<FileServer> { public: - FileServer(const string& _path) + explicit FileServer(const string& _path) : path(_path) {} virtual void initialize()
