Repository: mesos Updated Branches: refs/heads/master 6af543211 -> 4f321cf66
Improved the signal handling comment in Mesos tests. Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/4f321cf6 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/4f321cf6 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/4f321cf6 Branch: refs/heads/master Commit: 4f321cf660bc97fa1cac20964a584ba58e744a35 Parents: 6af5432 Author: Vinod Kone <[email protected]> Authored: Wed Aug 27 16:33:57 2014 -0700 Committer: Vinod Kone <[email protected]> Committed: Wed Aug 27 16:33:57 2014 -0700 ---------------------------------------------------------------------- src/tests/main.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/4f321cf6/src/tests/main.cpp ---------------------------------------------------------------------- diff --git a/src/tests/main.cpp b/src/tests/main.cpp index 42b1a58..90a7ddc 100644 --- a/src/tests/main.cpp +++ b/src/tests/main.cpp @@ -95,9 +95,12 @@ int main(int argc, char** argv) // Initialize logging. logging::initialize(argv[0], flags, true); - // We reset SIGPIPE default handler because some Mesos tests - // run an in-process ZooKeeper which results in SIGPIPE during - // ZooKeeeper server shutdown. See MESOS-1729 for details. + // We reset the signal handler setup by 'logging::initialize()' + // because some Mesos tests run an in-process ZooKeeper which + // results in SIGPIPE during ZooKeeeper server shutdown. See + // MESOS-1729 for details. This is ok because if a non-ZooKeeper + // test throws a SIGPIPE the default handler will still terminate + // the process, thus not masking SIGPIPE issues elsewhere. os::signals::reset(SIGPIPE); // Initialize gmock/gtest.
