Repository: mesos Updated Branches: refs/heads/master 217089091 -> e67a6a6b3
Fixed line comments end punctuation in libprocess. Review: https://reviews.apache.org/r/23709 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e67a6a6b Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e67a6a6b Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e67a6a6b Branch: refs/heads/master Commit: e67a6a6b3dbb4233a261242428da806cb7bc7c7e Parents: 2170890 Author: Timothy Chen <[email protected]> Authored: Tue Sep 9 22:24:06 2014 -0700 Committer: Niklas Q. Nielsen <[email protected]> Committed: Tue Sep 9 22:24:06 2014 -0700 ---------------------------------------------------------------------- 3rdparty/libprocess/include/process/check.hpp | 2 +- 3rdparty/libprocess/include/process/http.hpp | 4 ++-- 3rdparty/libprocess/include/process/protobuf.hpp | 2 +- 3rdparty/libprocess/include/process/sequence.hpp | 2 +- 3rdparty/libprocess/include/process/system.hpp | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/e67a6a6b/3rdparty/libprocess/include/process/check.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/check.hpp b/3rdparty/libprocess/include/process/check.hpp index 107446a..b3f9690 100644 --- a/3rdparty/libprocess/include/process/check.hpp +++ b/3rdparty/libprocess/include/process/check.hpp @@ -110,6 +110,6 @@ Option<std::string> _checkFailed(const process::Future<T>& f) return None(); } -// TODO(dhamon): CHECK_NPENDING, CHECK_NREADY, etc +// TODO(dhamon): CHECK_NPENDING, CHECK_NREADY, etc. #endif // __PROCESS_CHECK_HPP__ http://git-wip-us.apache.org/repos/asf/mesos/blob/e67a6a6b/3rdparty/libprocess/include/process/http.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/http.hpp b/3rdparty/libprocess/include/process/http.hpp index 05a3261..d540775 100644 --- a/3rdparty/libprocess/include/process/http.hpp +++ b/3rdparty/libprocess/include/process/http.hpp @@ -39,7 +39,7 @@ struct Request // Tracked by: https://issues.apache.org/jira/browse/MESOS-328. hashmap<std::string, std::string> headers; std::string method; - std::string url; // path?query#fragment + std::string url; // (path?query#fragment) std::string path; std::string fragment; hashmap<std::string, std::string> query; @@ -483,7 +483,7 @@ inline Try<std::string> decode(const std::string& s) continue; } - // We now expect two more characters: % HEXDIG HEXDIG + // We now expect two more characters: "% HEXDIG HEXDIG" if (i + 2 >= s.length() || !isxdigit(s[i+1]) || !isxdigit(s[i+2])) { return Error( "Malformed % escape in '" + s + "': '" + s.substr(i, 3) + "'"); http://git-wip-us.apache.org/repos/asf/mesos/blob/e67a6a6b/3rdparty/libprocess/include/process/protobuf.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/protobuf.hpp b/3rdparty/libprocess/include/process/protobuf.hpp index f3190f6..f3fc539 100644 --- a/3rdparty/libprocess/include/process/protobuf.hpp +++ b/3rdparty/libprocess/include/process/protobuf.hpp @@ -691,7 +691,7 @@ public: virtual ~ReqResProcess() { - // Discard the promise + // Discard the promise. promise.discard(); } http://git-wip-us.apache.org/repos/asf/mesos/blob/e67a6a6b/3rdparty/libprocess/include/process/sequence.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/sequence.hpp b/3rdparty/libprocess/include/process/sequence.hpp index 241afd2..d755b34 100644 --- a/3rdparty/libprocess/include/process/sequence.hpp +++ b/3rdparty/libprocess/include/process/sequence.hpp @@ -82,7 +82,7 @@ public: // +-->| F | +-->| F | +-->| F | // +---+ +---+ +---+ // - // Initial => Added one callback => Added two callbacks + // Initial => Added one callback => Added two callbacks. // Setup the "notification" from 'F' to 'N' so that when a // callback is done, signal the notifier ('N'). http://git-wip-us.apache.org/repos/asf/mesos/blob/e67a6a6b/3rdparty/libprocess/include/process/system.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/system.hpp b/3rdparty/libprocess/include/process/system.hpp index 48a02f0..4fb3c83 100644 --- a/3rdparty/libprocess/include/process/system.hpp +++ b/3rdparty/libprocess/include/process/system.hpp @@ -47,7 +47,7 @@ public: protected: virtual void initialize() { - // TODO(dhamon): Check return values + // TODO(dhamon): Check return values. metrics::add(load_1min); metrics::add(load_5min); metrics::add(load_15min);
