Repository: mesos
Updated Branches:
  refs/heads/master 60dd10cfb -> 9a25f5ef8


Pulled the log line in ZooKeeperTestServer::shutdownNetwork() to above the 
shutdown call.
- When debugging zookeeper related tests it's often more useful to know when 
the tests is shutting down the ZK server to reason about the order of events. 
Otherwise client disconnections are often logged before this "shutdown" line 
and can be confusing.

Review: https://reviews.apache.org/r/25511


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/9a25f5ef
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/9a25f5ef
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/9a25f5ef

Branch: refs/heads/master
Commit: 9a25f5ef8f23b7fa089a9e1178f2ce2a8103b771
Parents: fcb8dcb
Author: Jiang Yan Xu <y...@jxu.me>
Authored: Wed Sep 10 10:59:39 2014 -0700
Committer: Jiang Yan Xu <y...@jxu.me>
Committed: Wed Sep 10 22:34:00 2014 -0700

----------------------------------------------------------------------
 src/tests/zookeeper_test_server.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/9a25f5ef/src/tests/zookeeper_test_server.cpp
----------------------------------------------------------------------
diff --git a/src/tests/zookeeper_test_server.cpp 
b/src/tests/zookeeper_test_server.cpp
index a8c9b1c..d92ab8a 100644
--- a/src/tests/zookeeper_test_server.cpp
+++ b/src/tests/zookeeper_test_server.cpp
@@ -115,11 +115,11 @@ std::string ZooKeeperTestServer::connectString() const
 void ZooKeeperTestServer::shutdownNetwork()
 {
   if (connectionFactory != NULL && started) {
+    LOG(INFO) << "Shutting down ZooKeeperTestServer on port " << port;
     connectionFactory->shutdown();
     delete connectionFactory;
     connectionFactory = NULL;
     started = false;
-    LOG(INFO) << "Shutdown ZooKeeperTestServer on port " << port;
   }
 }
 

Reply via email to