My apologies - there should have been more context.

Should have been:
"Timeout only uses clock. Reduce inclusion to clock*.hpp* as opposed to all of
process.hpp. "

"future in socket.hpp" is a part of this work:
https://issues.apache.org/jira/browse/MESOS-1330

Niklas

On 23 October 2014 09:53, Benjamin Mahler <[email protected]> wrote:

> The commit message references Socket but the change is to remove an
> include in timeout.hpp?
>
> Sent from my iPhone
>
> > On Oct 23, 2014, at 9:01 AM, [email protected] wrote:
> >
> > Repository: mesos
> > Updated Branches:
> >  refs/heads/master 3a179ce2d -> fd0aa5248
> >
> >
> > Reduced over-include in libprocess Socket.
> >
> > Timeout only uses clock. Reduce inclusion to clock as opposed to all
> > of process.hpp. This helps prevent circular dependency when we include
> > future in socket.hpp.
> >
> > Review: https://reviews.apache.org/r/27024
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/fd0aa524
> > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/fd0aa524
> > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/fd0aa524
> >
> > Branch: refs/heads/master
> > Commit: fd0aa52480a63cff91f15fa4893f210b5e440c88
> > Parents: 3a179ce
> > Author: Joris Van Remoortere <[email protected]>
> > Authored: Thu Oct 23 15:12:18 2014 +0000
> > Committer: Niklas Q. Nielsen <[email protected]>
> > Committed: Thu Oct 23 15:12:45 2014 +0000
> >
> > ----------------------------------------------------------------------
> > 3rdparty/libprocess/include/process/timeout.hpp | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/mesos/blob/fd0aa524/3rdparty/libprocess/include/process/timeout.hpp
> > ----------------------------------------------------------------------
> > diff --git a/3rdparty/libprocess/include/process/timeout.hpp
> b/3rdparty/libprocess/include/process/timeout.hpp
> > index 40906cb..0bf63e1 100644
> > --- a/3rdparty/libprocess/include/process/timeout.hpp
> > +++ b/3rdparty/libprocess/include/process/timeout.hpp
> > @@ -1,7 +1,7 @@
> > #ifndef __PROCESS_TIMEOUT_HPP__
> > #define __PROCESS_TIMEOUT_HPP__
> >
> > -#include <process/process.hpp>
> > +#include <process/clock.hpp>
> >
> > #include <process/time.hpp>
> >
> >
>

Reply via email to