Repository: mesos Updated Branches: refs/heads/master 971129c8d -> d9ffd6bef
MESOS-1986: Deprecated disabling slave checkpointing. Review: https://reviews.apache.org/r/27120 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d9ffd6be Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d9ffd6be Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d9ffd6be Branch: refs/heads/master Commit: d9ffd6befb15ee1d2bb54c2d3760012875bb1930 Parents: 971129c Author: Cody Maloney <[email protected]> Authored: Fri Oct 24 10:40:34 2014 -0700 Committer: Vinod Kone <[email protected]> Committed: Fri Oct 24 10:41:12 2014 -0700 ---------------------------------------------------------------------- CHANGELOG | 4 +++- src/slave/flags.hpp | 1 + src/slave/slave.cpp | 5 +++++ 3 files changed, 9 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/d9ffd6be/CHANGELOG ---------------------------------------------------------------------- diff --git a/CHANGELOG b/CHANGELOG index 8ac81e5..ca3c6ad 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -2,8 +2,10 @@ -------------------------------------- * Deprecations: - * [MESOS-1807] Disallow executors with cpu only or memory only + * [MESOS-1807] - Disallow executors with cpu only or memory only resources. + * [MESOS-1986] - Disabling checkpointing is deprecated and the --checkpoint + flag will be removed in a future release. Release Notes - Mesos - Version 0.20.1 http://git-wip-us.apache.org/repos/asf/mesos/blob/d9ffd6be/src/slave/flags.hpp ---------------------------------------------------------------------- diff --git a/src/slave/flags.hpp b/src/slave/flags.hpp index 03c62a2..bdaa5d5 100644 --- a/src/slave/flags.hpp +++ b/src/slave/flags.hpp @@ -158,6 +158,7 @@ public: // TODO(vinod): Consider killing this flag and always checkpoint. add(&Flags::checkpoint, "checkpoint", + "This flag is deprecated and will be removed in a future release.\n" "Whether to checkpoint slave and frameworks information\n" "to disk. This enables a restarted slave to recover\n" "status updates and reconnect with (--recover=reconnect) or\n" http://git-wip-us.apache.org/repos/asf/mesos/blob/d9ffd6be/src/slave/slave.cpp ---------------------------------------------------------------------- diff --git a/src/slave/slave.cpp b/src/slave/slave.cpp index 55e5264..5e7c107 100644 --- a/src/slave/slave.cpp +++ b/src/slave/slave.cpp @@ -317,6 +317,11 @@ void Slave::initialize() LOG(INFO) << "Slave hostname: " << info.hostname(); LOG(INFO) << "Slave checkpoint: " << stringify(flags.checkpoint); + if (!flags.checkpoint) { + LOG(WARNING) << "Disabling checkpointing is deprecated and the --checkpoint" + " flag will be removed in a future release. Please avoid" + " using this flag"; + } statusUpdateManager->initialize(defer(self(), &Slave::forward, lambda::_1));
