Repository: mesos Updated Branches: refs/heads/master 8c582614b -> dd647025b
Future::failure should have a const ref return. Review: https://reviews.apache.org/r/27826 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/dd647025 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/dd647025 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/dd647025 Branch: refs/heads/master Commit: dd647025b361e512d564627ce0b6b8377627c84b Parents: 8c58261 Author: Dominic Hamon <[email protected]> Authored: Thu Aug 28 13:18:17 2014 -0700 Committer: Dominic Hamon <[email protected]> Committed: Mon Nov 10 16:12:02 2014 -0800 ---------------------------------------------------------------------- 3rdparty/libprocess/include/process/future.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/dd647025/3rdparty/libprocess/include/process/future.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp index bc8b878..3ac1812 100644 --- a/3rdparty/libprocess/include/process/future.hpp +++ b/3rdparty/libprocess/include/process/future.hpp @@ -141,7 +141,7 @@ public: const T& get() const; // Returns the failure message associated with this future. - std::string failure() const; + const std::string& failure() const; // Type of the callback functions that can get invoked when the // future gets set, fails, or is discarded. @@ -1170,7 +1170,7 @@ const T& Future<T>::get() const template <typename T> -std::string Future<T>::failure() const +const std::string& Future<T>::failure() const { if (data->state != FAILED) { ABORT("Future::failure() but state != FAILED");
