Repository: mesos
Updated Branches:
  refs/heads/master 949f3cedd -> b010e2297


Fixed unused comparisons on the == operator for TaskStatus.

Commit 8385bba added a comparison operator which added a ; instead of &&
ignoring most of the expression creating an expression result unused when
compiling with clang.

Review: https://reviews.apache.org/r/32034


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b010e229
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b010e229
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b010e229

Branch: refs/heads/master
Commit: b010e2297ce8dd9ed3971a25481d5c80ada8794a
Parents: 949f3ce
Author: Alexander Rojas <[email protected]>
Authored: Fri Mar 13 12:34:14 2015 +0100
Committer: Till Toenshoff <[email protected]>
Committed: Fri Mar 13 12:34:14 2015 +0100

----------------------------------------------------------------------
 src/common/type_utils.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/b010e229/src/common/type_utils.cpp
----------------------------------------------------------------------
diff --git a/src/common/type_utils.cpp b/src/common/type_utils.cpp
index c946991..e92f6f3 100644
--- a/src/common/type_utils.cpp
+++ b/src/common/type_utils.cpp
@@ -327,7 +327,7 @@ bool operator == (const SlaveInfo& left, const SlaveInfo& 
right)
 
 bool operator == (const TaskStatus& left, const TaskStatus& right)
 {
-  return left.task_id() == right.task_id();
+  return left.task_id() == right.task_id() &&
     left.state() == right.state() &&
     left.data() == right.data() &&
     left.message() == right.message() &&

Reply via email to