Repository: mesos Updated Branches: refs/heads/master 1b5851a8c -> a50674edc
Cleaned up style and comments in modules. Fixing minor style issues in modules and some misleading comments. Review: https://reviews.apache.org/r/32967 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/a50674ed Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/a50674ed Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/a50674ed Branch: refs/heads/master Commit: a50674edcd298d463a47fbbc428074be141fb293 Parents: 1b5851a Author: Aditi Dixit <[email protected]> Authored: Sun Apr 12 02:52:53 2015 +0200 Committer: Till Toenshoff <[email protected]> Committed: Sun Apr 12 02:52:53 2015 +0200 ---------------------------------------------------------------------- include/mesos/module.hpp | 3 +-- include/mesos/module/authenticatee.hpp | 5 ++--- include/mesos/module/authenticator.hpp | 5 ++--- include/mesos/module/hook.hpp | 5 ++--- include/mesos/module/isolator.hpp | 5 ++--- src/examples/test_anonymous_module.cpp | 2 +- src/examples/test_hook_module.cpp | 2 +- src/examples/test_isolator_module.cpp | 4 ++-- src/examples/test_module.hpp | 5 ++--- 9 files changed, 15 insertions(+), 21 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/include/mesos/module.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/module.hpp b/include/mesos/module.hpp index 5942126..01dd713 100644 --- a/include/mesos/module.hpp +++ b/include/mesos/module.hpp @@ -71,8 +71,7 @@ struct ModuleBase authorName(_authorName), authorEmail(_authorEmail), description(_description), - compatible(_compatible) - { } + compatible(_compatible) {} const char* moduleApiVersion; const char* mesosVersion; http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/include/mesos/module/authenticatee.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/module/authenticatee.hpp b/include/mesos/module/authenticatee.hpp index 94de988..aafca12 100644 --- a/include/mesos/module/authenticatee.hpp +++ b/include/mesos/module/authenticatee.hpp @@ -26,7 +26,7 @@ namespace mesos { namespace modules { -template<> +template <> inline const char* kind<mesos::Authenticatee>() { return "Authenticatee"; @@ -52,8 +52,7 @@ struct Module<mesos::Authenticatee> : ModuleBase _authorEmail, _description, _compatible), - create(_create) - { } + create(_create) {} mesos::Authenticatee* (*create)(const Parameters& parameters); }; http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/include/mesos/module/authenticator.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/module/authenticator.hpp b/include/mesos/module/authenticator.hpp index 6a83f17..b57938f 100644 --- a/include/mesos/module/authenticator.hpp +++ b/include/mesos/module/authenticator.hpp @@ -26,7 +26,7 @@ namespace mesos { namespace modules { -template<> +template <> inline const char* kind<mesos::Authenticator>() { return "Authenticator"; @@ -52,8 +52,7 @@ struct Module<mesos::Authenticator> : ModuleBase _authorEmail, _description, _compatible), - create(_create) - { } + create(_create) {} mesos::Authenticator* (*create)(const Parameters& parameters); }; http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/include/mesos/module/hook.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/module/hook.hpp b/include/mesos/module/hook.hpp index a474e2b..fdbc5b1 100644 --- a/include/mesos/module/hook.hpp +++ b/include/mesos/module/hook.hpp @@ -26,7 +26,7 @@ namespace mesos { namespace modules { -template<> +template <> inline const char* kind<mesos::Hook>() { return "Hook"; @@ -52,8 +52,7 @@ struct Module<mesos::Hook> : ModuleBase _authorEmail, _description, _compatible), - create(_create) - { } + create(_create) {} mesos::Hook* (*create)(const Parameters& parameters); }; http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/include/mesos/module/isolator.hpp ---------------------------------------------------------------------- diff --git a/include/mesos/module/isolator.hpp b/include/mesos/module/isolator.hpp index 452ad31..347d6d4 100644 --- a/include/mesos/module/isolator.hpp +++ b/include/mesos/module/isolator.hpp @@ -27,7 +27,7 @@ namespace mesos { namespace modules { -template<> +template <> inline const char* kind<mesos::slave::Isolator>() { return "Isolator"; @@ -54,8 +54,7 @@ struct Module<mesos::slave::Isolator> : ModuleBase _authorEmail, _description, _compatible), - create(_create) - { } + create(_create) {} mesos::slave::Isolator* (*create)(const Parameters& parameters); }; http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/src/examples/test_anonymous_module.cpp ---------------------------------------------------------------------- diff --git a/src/examples/test_anonymous_module.cpp b/src/examples/test_anonymous_module.cpp index 859f4e1..1535149 100644 --- a/src/examples/test_anonymous_module.cpp +++ b/src/examples/test_anonymous_module.cpp @@ -56,7 +56,7 @@ static Anonymous* createAnonymous(const Parameters& parameters) } -// Declares an anonymous module named 'TestAnonymous'. +// Declares an Anonymous module named 'org_apache_mesos_TestAnonymous'. mesos::modules::Module<Anonymous> org_apache_mesos_TestAnonymous( MESOS_MODULE_API_VERSION, MESOS_VERSION, http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/src/examples/test_hook_module.cpp ---------------------------------------------------------------------- diff --git a/src/examples/test_hook_module.cpp b/src/examples/test_hook_module.cpp index 47409cd..2f2da1c 100644 --- a/src/examples/test_hook_module.cpp +++ b/src/examples/test_hook_module.cpp @@ -92,7 +92,7 @@ static Hook* createHook(const Parameters& parameters) } -// Declares a Hook module named 'TestHook'. +// Declares a Hook module named 'org_apache_mesos_TestHook'. mesos::modules::Module<Hook> org_apache_mesos_TestHook( MESOS_MODULE_API_VERSION, MESOS_VERSION, http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/src/examples/test_isolator_module.cpp ---------------------------------------------------------------------- diff --git a/src/examples/test_isolator_module.cpp b/src/examples/test_isolator_module.cpp index 2c303f5..577dfca 100644 --- a/src/examples/test_isolator_module.cpp +++ b/src/examples/test_isolator_module.cpp @@ -67,7 +67,7 @@ static Isolator* createMemIsolator(const Parameters& parameters) } -// Declares a CPU Isolator module named 'testCpuIsolator'. +// Declares a CPU Isolator module named 'org_apache_mesos_TestCpuIsolator'. mesos::modules::Module<Isolator> org_apache_mesos_TestCpuIsolator( MESOS_MODULE_API_VERSION, MESOS_VERSION, @@ -78,7 +78,7 @@ mesos::modules::Module<Isolator> org_apache_mesos_TestCpuIsolator( createCpuIsolator); -// Declares a Memory Isolator module named 'testMemIsolator'. +// Declares a Memory Isolator module named 'org_apache_mesos_TestMemIsolator'. mesos::modules::Module<Isolator> org_apache_mesos_TestMemIsolator( MESOS_MODULE_API_VERSION, MESOS_VERSION, http://git-wip-us.apache.org/repos/asf/mesos/blob/a50674ed/src/examples/test_module.hpp ---------------------------------------------------------------------- diff --git a/src/examples/test_module.hpp b/src/examples/test_module.hpp index 041570e..0514963 100644 --- a/src/examples/test_module.hpp +++ b/src/examples/test_module.hpp @@ -53,7 +53,7 @@ public: namespace mesos { namespace modules { -template<> +template <> inline const char* kind<TestModule>() { return "TestModule"; @@ -79,8 +79,7 @@ struct Module<TestModule> : ModuleBase _authorEmail, _description, _compatible), - create(_create) - { } + create(_create) {} TestModule* (*create)(const Parameters& parameters); };
